health_check_grace_period default value for AWS ELB health checks for Autoscaling group

[anosulchik]

Looks like terraform sets health_check_grace_period to 0 (zero) as a default value when aws_autoscaling_group is configured with health_check_type = "ELB". According to AWS documentation it should be 300 (5 minutes):

By default, the health check grace period is 5 minutes

http://docs.aws.amazon.com/AutoScaling/latest/DeveloperGuide/healthcheck.html

[phinze]

Hi @anosulchik - in the API, the HealthCheckGracePeriod parameter is required when the HealthCheckType parameter is "ELB", otherwise you get an error message as reported in #3327.

We do have a note in the docs but it's a bit far down from the actual attribute reference.

I wonder if we should just pull the default of 300s down into Terraform as a default, which I believe would make the behavior a bit simpler for everybody. It has the tradeoff that if the default changes for whatever reason on the AWS side we'd have to play catch up, but it seems unlikely enough to not worry about.

/cc @stack72

[anosulchik]

Thanks for your reply, @phinze. To my opinion it would natural to make terraform to set default value the same as it does Amazon for ELB checks -- 300 sec. Just to prevent confusion that may case default value = 0 when this argument is not specified for ELB check in ASG.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.