provisioner/remote-exec: Move script cleanup after command wait #5751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phinze
force-pushed
the
phinze/fixup-remote-exec
branch
from
98adb7f
to
eae7b49
Compare
| // Upload a blank follow up file in the same path to prevent residual | ||
| // script contents from remaining on remote machine | ||
| empty := bytes.NewReader([]byte("")) | ||
| if err := comm.Upload(remotePath, empty); err != nil { |
There was a problem hiding this comment.
Is it desirable to retry this also still?
There was a problem hiding this comment.
Reworked to make this totally "best effort" - try once, only log on failure.
|
One minor question but otherwise LGTM |
phinze
force-pushed
the
phinze/fixup-remote-exec
branch
2 times, most recently
from
0b7e1fa
to
16e5498
Compare
phinze
force-pushed
the
phinze/fixup-remote-exec
branch
from
16e5498
to
579680c
Compare
phinze
added a commit
that referenced
this pull request
Mar 21, 2016
provisioner/remote-exec: Move script cleanup after command wait
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script cleanup step added in #5577 was positioned before the
cmd.Wait()call to ensure the command completes. This was causingnon-deterministic failures, especially for longer running scripts.
Fixes #5699
Fixes #5737