Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioner/remote-exec: Clear out scripts after uploading #5577

Merged
merged 1 commit into from
Mar 14, 2016

Conversation

phinze
Copy link
Contributor

@phinze phinze commented Mar 11, 2016

Prevents residual script contents from remaining on machine.

Fixes #482

Prevents residual script contents from remaining on machine.

Fixes #482
@phinze phinze force-pushed the phinze/remote-exec-empty-file branch from a142af3 to 96ebf0a Compare March 11, 2016 16:25
@stack72
Copy link
Contributor

stack72 commented Mar 14, 2016

LGTM!

phinze added a commit that referenced this pull request Mar 14, 2016
provisioner/remote-exec: Clear out scripts after uploading
@phinze phinze merged commit 76377c9 into master Mar 14, 2016
@phinze phinze deleted the phinze/remote-exec-empty-file branch March 14, 2016 14:54
phinze added a commit that referenced this pull request Mar 21, 2016
The script cleanup step added in #5577 was positioned before the
`cmd.Wait()` call to ensure the command completes. This was causing
non-deterministic failures, especially for longer runnings scripts.

Fixes #5699
Fixes #5737
phinze added a commit that referenced this pull request Mar 21, 2016
The script cleanup step added in #5577 was positioned before the
`cmd.Wait()` call to ensure the command completes. This was causing
non-deterministic failures, especially for longer running scripts.

Fixes #5699
Fixes #5737
phinze added a commit that referenced this pull request Mar 21, 2016
The script cleanup step added in #5577 was positioned before the
`cmd.Wait()` call to ensure the command completes. This was causing
non-deterministic failures, especially for longer running scripts.

Fixes #5699
Fixes #5737
phinze added a commit that referenced this pull request Mar 21, 2016
The script cleanup step added in #5577 was positioned before the
`cmd.Wait()` call to ensure the command completes. This was causing
non-deterministic failures, especially for longer running scripts.

Fixes #5699
Fixes #5737
phinze added a commit that referenced this pull request Mar 21, 2016
The script cleanup step added in #5577 was positioned before the
`cmd.Wait()` call to ensure the command completes. This was causing
non-deterministic failures, especially for longer running scripts.

Fixes #5699
Fixes #5737
@ghost
Copy link

ghost commented Apr 27, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

provisioner remote-exec > uploaded commands should be wiped out after exec
2 participants