azurerm: Can't enable ipv4_forwarding on a NIC

[colemickens]

Affected resource: azurerm_network_interface

[stack72]

Hi @colemickens

Thanks for opening the issue here. Can you point out (in the docs or the SDK) how we can add this? I can get it added easily then

FTR, if this is part of the new SDK, then I am having a lot of issues upgrading to it atm as this had serious breaking changes to how we were using it. So it may be slower if it's part of that SDK

P.

[colemickens]

Hi @stack72,

It should just be a matter of adding an option to https://github.com/hashicorp/terraform/blob/master/builtin/providers/azurerm/resource_arm_network_interface_card.go to also affect iface.EnableIPForwarding.

https://godoc.org/github.com/Azure/azure-sdk-for-go/arm/network#InterfacePropertiesFormat

This should exist even in older versions of the Go SDK.

[colemickens]

Also, please feel free to reach out if there are specific upgrade pain points and I can advise on how to handle the changes. I think most of the breaking changes have been needed to support other Azure clouds besides public cloud and to properly support long-running operations, and shouldn't be terribly difficult to adopt. Let me know.

[jen20]

@colemickens The biggest problem is that polling no longer appears to be handled internally. Underneath I couldn't care less whether you are polling, I just want the ID out of the request when it is finished. We must block in all cases anyway. See jen20/riviera for a more optimal way of dealing with polling.

[stack72]

@colemickens thanks for the link - i guess it was implemented the first time around as it wasn't in the docs - https://msdn.microsoft.com/en-us/library/mt163668.aspx

Adding it now :)

[colemickens]

Oh.... thanks for pointing that out. I'll try to see about getting that fixed.

And thanks for adding the feature as well!

[stack72]

Closed by #6807

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.