Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using concat on lists of maps #7030

Closed
oillio opened this issue Jun 6, 2016 · 3 comments
Closed

Crash when using concat on lists of maps #7030

oillio opened this issue Jun 6, 2016 · 3 comments

Comments

@oillio
Copy link

oillio commented Jun 6, 2016

Terraform Version

Terraform v0.7.0-rc1 (301da85)

Terraform Configuration Files

Module:

variable "foo" {
  type = "list"
}
variable "bar" {
  type = "list"
}

output "outFoo" {
  value = "${concat(var.foo,var.bar)}"
}

Calling:

module "envTesting" {
  source = "../modules"
  foo {
    value     = "aVal"
  }
  foo {
    value     = "anotherVal"
  }
  bar {
    value     = "thirdVal"
  }
  bar {
    value     = "finalVal"
  }
}

Panic Output

https://gist.github.com/oillio/ad293c464de43f7ff10efe8b0ceac466

phinze added a commit that referenced this issue Jun 12, 2016
The `concat()` interpolation function does not yet support types other
than strings / lists of strings. Make it an error message instead of a
panic when a list of non-primitives is supplied.

Fixes the panic in #7030
phinze added a commit that referenced this issue Jun 12, 2016
The `concat()` interpolation function does not yet support types other
than strings / lists of strings. Make it an error message instead of a
panic when a list of non-primitives is supplied.

Fixes the panic in #7030
@phinze
Copy link
Contributor

phinze commented Jun 12, 2016

Hi @oillio - thanks for this report. I've reproduced and fixed up the crash with a quick solution for now in #7145, which turns it into an error message. Getting concat() to support lists of complex types is its own task that I'm spinning up into a fresh issue, which I'll link back here. 👍

phinze added a commit that referenced this issue Jun 12, 2016
The `concat()` interpolation function does not yet support types other
than strings / lists of strings. Make it an error message instead of a
panic when a list of non-primitives is supplied.

Fixes the panic in #7030
@phinze
Copy link
Contributor

phinze commented Jun 12, 2016

Ok just double checked that the crasher is now fixed. Continued discussion of expected behavior can happen over in #7146

@phinze phinze closed this as completed Jun 12, 2016
@ghost
Copy link

ghost commented Apr 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants