Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_vpn_gateway not re-created when in deleted state #7859

Closed
clstokes opened this issue Jul 29, 2016 · 1 comment · Fixed by #7861
Closed

aws_vpn_gateway not re-created when in deleted state #7859

clstokes opened this issue Jul 29, 2016 · 1 comment · Fixed by #7861

Comments

@clstokes
Copy link
Contributor

If a aws_vpn_gateway is deleted out-of-band of Terraform and is in the deleted state then Terraform will not re-create it until it's no longer returned from the AWS API. Once the gateway is no longer returned from the AWS API, Terraform re-creates it correctly.

Terraform Version

  • 0.6.16
  • 0.7-rc3

Affected Resource(s)

  • aws_vpn_gateway

Terraform Configuration Files

resource "aws_vpc" "main" {
  cidr_block = "10.0.0.0/16"
}

resource "aws_vpn_gateway" "main" {
  vpc_id = "${aws_vpc.main.id}"
}

output "vpc_id" { value = "${aws_vpc.main.id}" }
output "vpn_id" { value = "${aws_vpn_gateway.main.id}" }

Expected Behavior

Terraform should re-create the VPN gateway that's in deleted state.

Actual Behavior

Terraform sees no changes are needed.

Steps to Reproduce

  1. terraform apply
  2. aws ec2 detach-vpn-gateway --vpc-id $(terraform output vpc_id) --vpn-gateway-id $(terraform output vpn_id)
  3. aws ec2 delete-vpn-gateway --vpn-gateway-id $(terraform output vpn_id)
  4. terraform plan

References

@stack72 stack72 self-assigned this Jul 29, 2016
stack72 added a commit that referenced this issue Jul 29, 2016
deleted state

Fixes #7859

When a VPN Gateway has been manually deleted, we should expect it to be
added back to the plan

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpnGateway_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpnGateway_
-timeout 120m
=== RUN   TestAccAWSVpnGateway_importBasic
--- PASS: TestAccAWSVpnGateway_importBasic (247.94s)
=== RUN   TestAccAWSVpnGateway_basic
--- PASS: TestAccAWSVpnGateway_basic (409.50s)
=== RUN   TestAccAWSVpnGateway_reattach
--- PASS: TestAccAWSVpnGateway_reattach (211.33s)
=== RUN   TestAccAWSVpnGateway_delete
--- PASS: TestAccAWSVpnGateway_delete (121.10s)
=== RUN   TestAccAWSVpnGateway_tags
--- PASS: TestAccAWSVpnGateway_tags (125.38s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws
1115.274s
```
stack72 added a commit that referenced this issue Jul 29, 2016
…7861)

deleted state

Fixes #7859

When a VPN Gateway has been manually deleted, we should expect it to be
added back to the plan

```
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpnGateway_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpnGateway_
-timeout 120m
=== RUN   TestAccAWSVpnGateway_importBasic
--- PASS: TestAccAWSVpnGateway_importBasic (247.94s)
=== RUN   TestAccAWSVpnGateway_basic
--- PASS: TestAccAWSVpnGateway_basic (409.50s)
=== RUN   TestAccAWSVpnGateway_reattach
--- PASS: TestAccAWSVpnGateway_reattach (211.33s)
=== RUN   TestAccAWSVpnGateway_delete
--- PASS: TestAccAWSVpnGateway_delete (121.10s)
=== RUN   TestAccAWSVpnGateway_tags
--- PASS: TestAccAWSVpnGateway_tags (125.38s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws
1115.274s
```
kwilczynski added a commit to kwilczynski/terraform that referenced this issue Aug 1, 2016
Related to hashicorp#7859.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
kwilczynski added a commit to kwilczynski/terraform that referenced this issue Aug 1, 2016
Related to hashicorp#7859.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
kwilczynski added a commit to kwilczynski/terraform that referenced this issue Aug 4, 2016
Related to hashicorp#7859.

Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost unassigned stack72 Apr 23, 2020
@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants