Use standard AWS environment variables #851
Conversation
This is 100% backwards-compatible
sethvargo
force-pushed
the
sethvargo/aws_envvars
branch
from
ada18d4
to
5713b7a
Compare
|
Following the preferred/standard AWS naming would (IMHO) indeed make sense. But personally I would not make the Allowing/supporting both variable names should be a temporary thing if you ask me. So maybe deprecate the old names for a few versions and with the 0.4.0 release (for example) only allow the new names and cleanup this temp fix/workaround? My 2cts... |
|
@svanharmelen that was my original intention. You can't see it from the git history, but the original prototype was to add a private func to As a general rule, it looks like Terraform follows the What do you think? I'm more than happy to move it back to a private func on the AWS provider 😄 |
|
Well... Personally I don't mind that much which name to use for the vars, as they both seem to have a valid thought behind them. The current one being inline with the others within TF, the latter one being inline with the AWS standards. So I think maybe @armon or @mitchellh (who once choose the var names for this provider) are better candidates to have an opinion about what envvar names to use here. But either way I do think that whatever the name should be, we should only one support 1 name for a given envvar and not multiple as it will only confuse things and make support cases more unclear. So if the naming should change to the AWS standard names, then indeed I would prefer it to be a temp (for a few versions) private func inside the AWS provider... |
|
I agree. Let's do it a temporary backwards compatible fix, but eventually deprecate. I do think |
Use standard AWS environment variables
|
Created #866 to track the deprecation. |
Terraform [now supports get the AWS credentials from the standard environment variables](hashicorp/terraform#851). To make it work, you should not specify 'access_key' or 'secret_key' in the provider definition. We also need to remove the variables as we don't use them.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Fixes #850, but maintains backwards compatibility.
/cc @mitchellh @svanharmelen