Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dme - DNSMadeEasy Provider #855

Merged
merged 2 commits into from
Feb 25, 2015
Merged

dme - DNSMadeEasy Provider #855

merged 2 commits into from
Feb 25, 2015

Conversation

soniah
Copy link
Contributor

@soniah soniah commented Jan 23, 2015

Pull request for dme - DNSMadeEasy Provider. See also issue #829.

The DNSMadeEasy REST API has probably grown over time, and is slightly
inconsistent. Most DNS record types take a 'value' field, however
this value field is sometimes named something else in the web interface.
Also, some record types require fields in addtion to 'value'.

I've attempted to document these requirements in my documentation - let me
know if you'd like me to lay out the documentation in a different manner, to
conform with your standards.

Cloned from https://github.com/soniah/terraform-provider-dme, and
the following files removed:

* .gitignore
* .travis.yml
* AUTHORS.md
* LICENSE
* README.md
@soniah
Copy link
Contributor Author

soniah commented Jan 23, 2015

I removed my .travis.yml from my code - should I add it to the main .travis.yml?

Also, I ran my tests do the following, and they passed

TF_ACC=1 DME_AKEY=deadbeaf-deadbeef DME_SKEY=deadbeaf-deadbeef DME_DOMAINID=123456 DME_USESANDBOX='true'  go test ./builtin/providers/dnsmadeeasy -v  -timeout 45m

However doing the following gave me errors about unset environment vars (provider_test.go:34: DME_SKEY must be set for acceptance tests), I don't know how to setup testacc correctly:

make testacc TEST=./builtin/providers/dnsmadeeasy TESTARGS='DME_AKEY=deadbeef DME_SKEY=deadbeef DME_DOMAINID=123456 DME_USESANDBOX="true"'

@svanharmelen
Copy link
Contributor

Something like this should work:

DME_AKEY=deadbeef DME_SKEY=deadbeef DME_DOMAINID=123456 DME_USESANDBOX="true" make testacc TEST=./builtin/providers/dnsmadeeasy

TESTARGS in this case is used to specify which test you want to run. If not specified it will run all tests.... See some additional info about testacc at the bottom of the README.md:

The TEST variable is required, and you should specify the folder where the provider is. The
TESTARGS variable is recommended to filter down to a specific resource to test, since testing
all of them at once can take a very long time.

@mitchellh
Copy link
Contributor

This looks great! We're currently going through and doing a merge for 0.3.7, and we'll look at this for 0.4.0 since it is a new provider.

@hh
Copy link

hh commented Feb 17, 2015

TLDR; How do you create the terraform-provider-dme binary?

I'm new to go, and I couldn't find any documentation on how to actually build the binary for use with 0.3.6.

From https://github.com/soniah/terraform-provider-dme#installation

install the Terraform development environment, build it using the Development Environment instructions

I did a make dev and got no errors.

install this project via go get github.com/soniah/terraform-provider-dme

This doesn't produce any files on disk that I can tell, nor a binary.

follow the instructions for Installing a Plugin detailed in Plugin Basics

This seems to document installing a binary, which I can't seem to generate or find yet.

@soniah
Copy link
Contributor Author

soniah commented Feb 17, 2015

Hi Hippy @hh. Good call, I'll update the docs to make things more explicit -- give me a day or two -- $PHB is keeping me busy at $WORK at the moment.

@soniah
Copy link
Contributor Author

soniah commented Feb 18, 2015

Hi @hh, I've updated the README, I hope it helps.

@soniah soniah closed this Feb 18, 2015
@soniah soniah reopened this Feb 18, 2015
@pearkes
Copy link
Contributor

pearkes commented Feb 25, 2015

Thanks, this looks great. One thing is the bin is in the wrong place, but I'll fix that after merge and cc you on the commit.

I couldn't run the acceptance tests due to not having a small business account (paid) with DNSMadeEasy, but I assume those are passing as of the PR. If you can confirm that, it'd be appreciated.

Also, if you know of a way to set-up and account for testing for us to use, I'd appreciate it. Going to merge this now though.

pearkes added a commit that referenced this pull request Feb 25, 2015
dme - DNSMadeEasy Provider
@pearkes pearkes merged commit dfaa428 into hashicorp:master Feb 25, 2015
@soniah
Copy link
Contributor Author

soniah commented Feb 26, 2015

Jack @pearkes quick reply to this and other stuff as I see you're working on this but I'm at work at the moment (Sydney time):

@hh
Copy link

hh commented Feb 26, 2015

Looks like we got a merge

On Wed, Feb 25, 2015 at 4:26 PM, Sonia Hamilton notifications@github.com
wrote:

Jack @pearkes https://github.com/pearkes quick reply to this and other
stuff as I see you're working on this but I'm at work at the moment (Sydney
time):


Reply to this email directly or view it on GitHub
#855 (comment).

@pearkes
Copy link
Contributor

pearkes commented Feb 26, 2015

@soniah Cool, thanks, I'll sign up for that. Note with the rename that the binary named changed, so anything local you're running now will need to be updated if you're using master to build.

@ghost
Copy link

ghost commented May 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants