-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dme - DNSMadeEasy Provider #855
Conversation
Cloned from https://github.com/soniah/terraform-provider-dme, and the following files removed: * .gitignore * .travis.yml * AUTHORS.md * LICENSE * README.md
I removed my .travis.yml from my code - should I add it to the main .travis.yml? Also, I ran my tests do the following, and they passed
However doing the following gave me errors about unset environment vars (provider_test.go:34: DME_SKEY must be set for acceptance tests), I don't know how to setup testacc correctly:
|
Something like this should work:
|
This looks great! We're currently going through and doing a merge for 0.3.7, and we'll look at this for 0.4.0 since it is a new provider. |
TLDR; How do you create the terraform-provider-dme binary? I'm new to go, and I couldn't find any documentation on how to actually build the binary for use with 0.3.6. From https://github.com/soniah/terraform-provider-dme#installation
I did a make dev and got no errors.
This doesn't produce any files on disk that I can tell, nor a binary.
This seems to document installing a binary, which I can't seem to generate or find yet. |
Hi Hippy @hh. Good call, I'll update the docs to make things more explicit -- give me a day or two -- $PHB is keeping me busy at $WORK at the moment. |
Hi @hh, I've updated the README, I hope it helps. |
Thanks, this looks great. One thing is the bin is in the wrong place, but I'll fix that after merge and cc you on the commit. I couldn't run the acceptance tests due to not having a small business account (paid) with DNSMadeEasy, but I assume those are passing as of the PR. If you can confirm that, it'd be appreciated. Also, if you know of a way to set-up and account for testing for us to use, I'd appreciate it. Going to merge this now though. |
Jack @pearkes quick reply to this and other stuff as I see you're working on this but I'm at work at the moment (Sydney time):
|
Looks like we got a merge On Wed, Feb 25, 2015 at 4:26 PM, Sonia Hamilton notifications@github.com
|
@soniah Cool, thanks, I'll sign up for that. Note with the rename that the binary named changed, so anything local you're running now will need to be updated if you're using master to build. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Pull request for dme - DNSMadeEasy Provider. See also issue #829.
The DNSMadeEasy REST API has probably grown over time, and is slightly
inconsistent. Most DNS record types take a 'value' field, however
this value field is sometimes named something else in the web interface.
Also, some record types require fields in addtion to 'value'.
I've attempted to document these requirements in my documentation - let me
know if you'd like me to lay out the documentation in a different manner, to
conform with your standards.