Regression in loading variables.tf.json from module

[phinze]

Terraform Version

0.7.3

Terraform Configuration Files

module "ami" {
  source        = "github.com/terraform-community-modules/tf_aws_ubuntu_ami/ebs"
  instance_type = "t2.micro"
  region        = "us-east-1"
  distribution  = "trusty"
}

output "ami" {
  value = "${module.ami.ami_id}"
}

Steps to Reproduce

1. terraform get

Expected Behavior

• Successful exit

Actual Behavior

Get: git::https://github.com/terraform-community-modules/tf_aws_ubuntu_ami.git
Get: git::https://github.com/terraform-community-modules/tf_aws_virttype.git
Get: file:///Users/phinze/tmp/tf/amimoderror/.terraform/modules/0ec790a5c99e8db6524c7ac02e48e712
Error loading Terraform: module ami.root: module virttype: required variable prefer_pv not set

Important Factoids

• The submodule expects variables.tf.json to define the default value for prefer_pv
• Works fine on Terraform 0.7.2
• Running master w/ fixes in update github.com/hashicorp/go-getter #8803 do not resolve the issue.

References

• config/module: use source as part of key #8398 - Instigating change
• Module not found, may need to be downloaded using 'terraform get' #8724 - Related bug
• update github.com/hashicorp/go-getter #8803 - Related but insufficient bugfix

[jbardin]

The breaking commit turns out to be #8591 (specifically 609219f)

[jbardin]

The root cause is a bug in HCL: hashicorp/hcl#153

[jbiel]

Thanks for the fix, this hit me on 0.7.3. When I passed the config file via -var-file... I still ended up with some kind of parsing issue because I received an error ("unknown variable accessed".) Master works (but I keep trying to get away from running it!)

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.