Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_instance: tags with empty value are not applied #968

Closed
patricklucas opened this issue Feb 11, 2015 · 2 comments · Fixed by #989
Closed

aws_instance: tags with empty value are not applied #968

patricklucas opened this issue Feb 11, 2015 · 2 comments · Fixed by #989
Assignees
@mitchellh
Labels
bug provider/aws

Comments

@patricklucas
Copy link

It is valid for AWS resource tags to have a key but no value, but Terraform does not successfully create them.

Terraform indicates that it wants to increase the tag count, but it does not actually create the resource unless I add a non-empty value:

~ aws_instance.foo-1
    tags.#: "3" => "4"

~ aws_instance.foo-1
    tags.#:                "3" => "4"
    tags.puppet:role::foo: "" => "a"
@mitchellh mitchellh self-assigned this Feb 17, 2015
mitchellh added a commit that referenced this issue Feb 17, 2015
@mitchellh
helper/schema: empty map values should show up in diff [GH-968]
5c06cc3
@mitchellh mitchellh mentioned this issue Feb 17, 2015
Merged
@mitchellh
Copy link
Contributor

Thanks! This will be fixed with the PR above once I get a review.

mitchellh added a commit that referenced this issue Feb 18, 2015
@mitchellh
Merge pull request #989 from hashicorp/b-empty-map
7f6e13a 
helper/schema: empty map values should show up in diff [GH-968]
catsby added a commit that referenced this issue Feb 18, 2015
@catsby
Merge branch 'master' into aws-go-route53
211ad8d 
* master:
  update cHANGELOG
  helper/schema: zero value of a set should be empty
  helper/schema: GetOk now only returns true if set to non-zero value
  update CHANGELOG
  providers/aws: fix bad arg giving wrong type [GH-992]
  update CHANGELOG
  update CHANGELOG
  Update CHANGELOG
  update CHANGELOG
  providers/aws: test for allowing in-place lC update
  providers/aws: support updating ASG launch config [GH-904]
  helper/schema: GetChange shouldn't return true when no change
  helper/schema: empty map values should show up in diff [GH-968]
  helper/schema: clarify test
  helper/schema: show in diff when no config is going to empty set
  config: bare splat variables should not be allowed in provisioners
yahyapo pushed a commit to yahyapo/terraform that referenced this issue Mar 13, 2015
@mitchellh
helper/schema: empty map values should show up in diff [hashicorpGH-968]
73d3f3d
@ghost
Copy link

ghost commented May 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mitchellh mitchellh

Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helper/schema: empty map values should show up in diff [GH-968] hashicorp/terraform
2 participants
@mitchellh @patricklucas