Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener #10180

Merged
merged 1 commit into from
Nov 17, 2016
Merged

provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener #10180

merged 1 commit into from
Nov 17, 2016

Conversation

vancluever
Copy link
Contributor

Looks like sometimes it takes some time for IAM certificates to
propagate, which can cause errors on ALB listener creation.
Possibly same thing as #5178, but for ALB
now instead of ELB.

This was discovered via acceptance tests, specifically the
TestAccAWSALBListener_https test. Updated the creation process to wait
on CertificateNotFound for a max of 5min.

provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener
c129f71 
Looks like sometimes it takes some time for IAM certificates to
propagate, which can cause errors on ALB listener creation.
Possibly same thing as hashicorp#5178, but for ALB
now instead of ELB.

This was discovered via acceptance tests, specifically the
TestAccAWSALBListener_https test. Updated the creation process to wait
on CertificateNotFound for a max of 5min.
vancluever pushed a commit to paybyphone/terraform that referenced this pull request Nov 17, 2016
provider/aws: Add aws_alb_listener data source
d8b5bea 
This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.
@vancluever vancluever mentioned this pull request Nov 17, 2016
Merged
@stack72
Copy link
Contributor

stack72 commented Nov 17, 2016

Hi @vancluever

this LGTM! Thanks for this - this was definitely an annoying bug

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSALBListener_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/11/17 14:45:57 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSALBListener_ -timeout 120m
=== RUN   TestAccAWSALBListener_basic
--- PASS: TestAccAWSALBListener_basic (75.88s)
=== RUN   TestAccAWSALBListener_https
--- PASS: TestAccAWSALBListener_https (72.40s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    148.298s

@stack72 stack72 merged commit 99528f1 into hashicorp:master Nov 17, 2016
stack72 pushed a commit that referenced this pull request Nov 17, 2016
@vancluever @stack72
provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener (
f5a49c2 
#10180)

Looks like sometimes it takes some time for IAM certificates to
propagate, which can cause errors on ALB listener creation.
Possibly same thing as #5178, but for ALB
now instead of ELB.

This was discovered via acceptance tests, specifically the
TestAccAWSALBListener_https test. Updated the creation process to wait
on CertificateNotFound for a max of 5min.
jrnt30 pushed a commit to jrnt30/terraform that referenced this pull request Nov 17, 2016
@vancluever @jrnt30
provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener (
a4545b3 
hashicorp#10180)

Looks like sometimes it takes some time for IAM certificates to
propagate, which can cause errors on ALB listener creation.
Possibly same thing as hashicorp#5178, but for ALB
now instead of ELB.

This was discovered via acceptance tests, specifically the
TestAccAWSALBListener_https test. Updated the creation process to wait
on CertificateNotFound for a max of 5min.
@vancluever
Copy link
Contributor Author

Thanks @stack72! Helps set the stage for #10181 and another one I'll have incoming this morning!

@vancluever vancluever deleted the pbp_b_alb_listener_certnotfound_retry branch November 17, 2016 15:27
vancluever pushed a commit to paybyphone/terraform that referenced this pull request Nov 17, 2016
provider/aws: Add aws_alb_listener data source
01aadd5 
This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.
stack72 pushed a commit that referenced this pull request Nov 18, 2016
@vancluever @stack72
provider/aws: Add aws_alb_listener data source (#10181)
3ac05a5 
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
stack72 pushed a commit that referenced this pull request Nov 18, 2016
@vancluever @stack72
provider/aws: Add aws_alb_listener data source (#10181)
7088126 
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@vancluever
provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener (
35bc7de 
hashicorp#10180)

Looks like sometimes it takes some time for IAM certificates to
propagate, which can cause errors on ALB listener creation.
Possibly same thing as hashicorp#5178, but for ALB
now instead of ELB.

This was discovered via acceptance tests, specifically the
TestAccAWSALBListener_https test. Updated the creation process to wait
on CertificateNotFound for a max of 5min.
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@vancluever
provider/aws: Add aws_alb_listener data source (hashicorp#10181)
21f3d10 
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
@vancluever @fatmcgav
provider/aws: Add CertificateNotFound retry waiter to aws_alb_listener (
464e2a2 
hashicorp#10180)

Looks like sometimes it takes some time for IAM certificates to
propagate, which can cause errors on ALB listener creation.
Possibly same thing as hashicorp#5178, but for ALB
now instead of ELB.

This was discovered via acceptance tests, specifically the
TestAccAWSALBListener_https test. Updated the creation process to wait
on CertificateNotFound for a max of 5min.
fatmcgav pushed a commit to fatmcgav/terraform that referenced this pull request Feb 27, 2017
@vancluever @fatmcgav
provider/aws: Add aws_alb_listener data source (hashicorp#10181)
bb7df2d 
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
grubernaut pushed a commit to hashicorp/terraform-provider-aws that referenced this pull request Jun 9, 2017
@vancluever @stack72
provider/aws: Add aws_alb_listener data source (#10181)
6aecb08 
* provider/aws: Add aws_alb_listener data source

This adds the aws_alb_listener data source to get information on an AWS
Application Load Balancer listener.

The schema is slightly modified (only option-wise, attributes are the
same) and we use the aws_alb_listener resource read function to get the
data.

Note that the HTTPS test here may fail due until
hashicorp/terraform#10180 is merged.

* provider/aws: Add aws_alb_listener data source docs

Now documented.
@ghost
Copy link

ghost commented Apr 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vancluever @stack72