Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] provider/azurerm: create app_gateway resource #10413

Closed
wants to merge 1 commit into from

Conversation

pmcatominey
Copy link
Contributor

Todo:

  • Fix Create failing with status 200 error
  • Add import test
  • Documentation

@bpoland
Copy link

bpoland commented Jan 31, 2017

Would be great to see this resource added -- does anyone know when this will get merged?

@retheshnair
Copy link

@stack72 Any help on this will be appreciated

@bpoland
Copy link

bpoland commented Mar 15, 2017

@pmcatominey would you consider also updating the VM Scale Set to allow them to be added to an app gateway backend pool? This would be similar to the existing load_balancer_backend_address_pool_ids for load balancers.
https://www.terraform.io/docs/providers/azurerm/r/virtual_machine_scale_sets.html

And the network interface also has load_balancer_backend_address_pool_ids so it would make sense to add it there too: https://www.terraform.io/docs/providers/azurerm/r/network_interface.html

@choppedpork
Copy link

This is amazing @pmcatominey - thanks a lot! I've built terraform from your branch and haven't ran into any problems (using the unit test as documentation... :) - would be great to see this merged.

@benkoller
Copy link

Great work, a merge of this would be terrific!

@bpoland bpoland mentioned this pull request Apr 12, 2017
@gyoza
Copy link

gyoza commented Apr 28, 2017

Anybody know any if or if not this will get merged into terraform?

@brandontosch
Copy link
Contributor

I'm trying to jump on this to revive it, just been trying to find the time. Things have changed a bit since November of last year (when this was opened) so there was a little refactoring to do. Have it mostly working now so hopefully not much longer.

@blucas-accela
Copy link

+1

@dominik-lekse
Copy link
Contributor

@brandontosch Is it possible to publish your draft as WIP pull request?

@brandontosch
Copy link
Contributor

@dominik-lekse Sorry for the delay, been swamped. Opened up WIP PR #14426

@pmcatominey
Copy link
Contributor Author

Superseded by #14426.

@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants