provider/github: Implements github_branch_protection #10476
Conversation
alindeman
force-pushed
the
github-branch-protection
branch
2 times, most recently
from
231bfae
to
17fb7ff
Compare
alindeman
force-pushed
the
github-branch-protection
branch
from
17fb7ff
to
bf0b62d
Compare
|
Any update to this? |
alindeman
force-pushed
the
github-branch-protection
branch
3 times, most recently
from
329e810
to
df280ec
Compare
|
@stack72 @jason-riddle I've rebased this on 0.9.1 and added support for |
alindeman
force-pushed
the
github-branch-protection
branch
from
df280ec
to
195f415
Compare
|
Hi @alindeman Thanks for the work here - can you tell me if this is still in preview? P. |
There was a problem hiding this comment.
hi @alindeman
This LGTM! I have 1 question inline that we can fix up at another time if necessary :)
Paul
|
|
||
| githubProtection, _, err := client.Repositories.GetBranchProtection(context.TODO(), meta.(*Organization).name, r, b) | ||
| if err != nil { | ||
| d.SetId("") |
There was a problem hiding this comment.
Do we want to refresh from state on every error ?
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This PR introduces a new resource,
github_branch_protection, that configures branch protection for a given repository and branch.The API required in go-github landed in google/go-github#476 and are included in a single commit a2da126 in this branch.
The Protected Branches API is still in a preview period, meaning it may change (including breaking changes). I'm open to keeping this PR open until it stabilizes, but I could also see it being useful to folks now (with a warning that it is not fully stable). I'm open to hearing feedback on that point.
/cc: @sr