provider/aws: Implement IPV6 Support for ec2 / VPC #10538

stack72 · 2016-12-05T18:42:55Z

aws_vpc support added
aws_egress_only_internet_gateway
aws_subnet support added
aws_instance support added

apparentlymart · 2016-12-05T19:07:47Z

builtin/providers/aws/resource_aws_vpc.go

@@ -55,6 +55,13 @@ func resourceAwsVpc() *schema.Resource {
 				Computed: true,
 			},

+			"assign_amazon_ipv6_cidr_block": {


This name feels a little strange... having read the docs I now understand what you meant by "amazon" here but it reads as if "Amazon IPv6" is some sort of product name.

I must admit I'm not sure what to suggest as an alternative. assign_generated_ipv6_cidr_block is one idea that came to mind, though it's long. Perhaps assign_generated_ipv6_range is a shorter way of saying it. I also wonder if the word "assign" already has the "chosen by someone else" meaning embedded in it enough, so that assign_ipv6_range would be sufficient to get the point across.

Feel free to ignore me, since I know this is not the most constructive comment... 😖

Totally agreed :) Made the change to assign_generated_ipv6_cidr_block - i went with generated so it was closer to the AWS docs

stack72 · 2017-02-28T13:40:16Z

VPC Tests:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpc_'                                                 
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/28 12:36:37 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpc_ -timeout 120m
=== RUN   TestAccAWSVpc_importBasic
--- PASS: TestAccAWSVpc_importBasic (55.76s)
=== RUN   TestAccAWSVpc_basic
--- PASS: TestAccAWSVpc_basic (41.47s)
=== RUN   TestAccAWSVpc_enableIpv6
--- PASS: TestAccAWSVpc_enableIpv6 (67.65s)
=== RUN   TestAccAWSVpc_dedicatedTenancy
--- PASS: TestAccAWSVpc_dedicatedTenancy (121.01s)
=== RUN   TestAccAWSVpc_tags
--- PASS: TestAccAWSVpc_tags (121.15s)
=== RUN   TestAccAWSVpc_update
--- PASS: TestAccAWSVpc_update (187.46s)
=== RUN   TestAccAWSVpc_bothDnsOptionsSet
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (20.11s)
=== RUN   TestAccAWSVpc_DisabledDnsSupport
--- PASS: TestAccAWSVpc_DisabledDnsSupport (94.21s)
=== RUN   TestAccAWSVpc_classiclinkOptionSet
--- PASS: TestAccAWSVpc_classiclinkOptionSet (146.69s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	855.536s

Subnet Tests:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSubnet_'                                               
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/28 12:54:18 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSubnet_ -timeout 120m
=== RUN   TestAccAWSSubnet_importBasic
--- PASS: TestAccAWSSubnet_importBasic (92.15s)
=== RUN   TestAccAWSSubnet_basic
--- PASS: TestAccAWSSubnet_basic (61.26s)
=== RUN   TestAccAWSSubnet_ipv6
--- PASS: TestAccAWSSubnet_ipv6 (120.25s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	273.686s

egress internet gateway:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEgressOnlyInternetGateway_'             
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/28 13:35:44 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEgressOnlyInternetGateway_ -timeout 120m
=== RUN   TestAccAWSEgressOnlyInternetGateway_basic
--- PASS: TestAccAWSEgressOnlyInternetGateway_basic (57.33s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	57.362s

Instance Tests:

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSInstance_'                                                      
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/02/28 12:34:14 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSInstance_ -timeout 120m
=== RUN   TestAccAWSInstance_importBasic
--- PASS: TestAccAWSInstance_importBasic (135.46s)
=== RUN   TestAccAWSInstance_basic
--- PASS: TestAccAWSInstance_basic (203.86s)
=== RUN   TestAccAWSInstance_rootInstanceStore
--- PASS: TestAccAWSInstance_rootInstanceStore (114.74s)
=== RUN   TestAccAWSInstance_sourceDestCheck
--- PASS: TestAccAWSInstance_sourceDestCheck (473.48s)
=== RUN   TestAccAWSInstance_disableApiTermination
--- PASS: TestAccAWSInstance_disableApiTermination (283.95s)
=== RUN   TestAccAWSInstance_vpc
--- PASS: TestAccAWSInstance_vpc (163.70s)
=== RUN   TestAccAWSInstance_ipv6_supportAddressCount
--- PASS: TestAccAWSInstance_ipv6_supportAddressCount (145.34s)
=== RUN   TestAccAWSInstance_NetworkInstanceSecurityGroups
--- PASS: TestAccAWSInstance_NetworkInstanceSecurityGroups (177.08s)
=== RUN   TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs
--- PASS: TestAccAWSInstance_NetworkInstanceVPCSecurityGroupIDs (176.94s)
=== RUN   TestAccAWSInstance_tags
--- PASS: TestAccAWSInstance_tags (159.90s)
=== RUN   TestAccAWSInstance_privateIP
--- PASS: TestAccAWSInstance_privateIP (153.08s)
=== RUN   TestAccAWSInstance_associatePublicIPAndPrivateIP
--- PASS: TestAccAWSInstance_associatePublicIPAndPrivateIP (167.74s)
=== RUN   TestAccAWSInstance_rootBlockDeviceMismatch
--- PASS: TestAccAWSInstance_rootBlockDeviceMismatch (143.69s)
=== RUN   TestAccAWSInstance_forceNewAndTagsDrift
--- PASS: TestAccAWSInstance_forceNewAndTagsDrift (231.97s)
=== RUN   TestAccAWSInstance_changeInstanceType
--- PASS: TestAccAWSInstance_changeInstanceType (162.21s)
PASS
ok	github.com/hashicorp/terraform/builtin/providers/aws	3276.841s

tombuildsstuff · 2017-03-01T15:25:32Z

website/source/docs/providers/aws/r/instance.html.markdown

@@ -77,6 +77,8 @@ instances. See [Shutdown Behavior](https://docs.aws.amazon.com/AWSEC2/latest/Use
 * `user_data` - (Optional) The user data to provide when launching the instance.
 * `iam_instance_profile` - (Optional) The IAM Instance Profile to
  launch the instance with.
+* `ipv6_address_count`- (Optional) A number of IPv6 addresses to associate with the primary network interface. Amazon EC2 chooses the IPv6 addresses from the range of your subnet.
+* `ipv6_addresses` - (Optional)


missing a description as per AWS docs

grubernaut

LGTM!

``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpc' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/12/09 14:07:31 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpc -timeout 120m === RUN TestAccAWSVpc_importBasic --- PASS: TestAccAWSVpc_importBasic (43.03s) === RUN TestAccAWSVpc_basic --- PASS: TestAccAWSVpc_basic (36.32s) === RUN TestAccAWSVpc_enableIpv6 --- PASS: TestAccAWSVpc_enableIpv6 (29.37s) === RUN TestAccAWSVpc_dedicatedTenancy --- PASS: TestAccAWSVpc_dedicatedTenancy (36.63s) === RUN TestAccAWSVpc_tags --- PASS: TestAccAWSVpc_tags (67.54s) === RUN TestAccAWSVpc_update --- PASS: TestAccAWSVpc_update (66.16s) === RUN TestAccAWSVpc_bothDnsOptionsSet --- PASS: TestAccAWSVpc_bothDnsOptionsSet (16.82s) === RUN TestAccAWSVpc_DisabledDnsSupport --- PASS: TestAccAWSVpc_DisabledDnsSupport (36.52s) === RUN TestAccAWSVpc_classiclinkOptionSet --- PASS: TestAccAWSVpc_classiclinkOptionSet (38.13s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 739.543s ```

``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEgressOnlyInternetGateway_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/12/09 14:22:16 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEgressOnlyInternetGateway_ -timeout 120m === RUN TestAccAWSEgressOnlyInternetGateway_basic --- PASS: TestAccAWSEgressOnlyInternetGateway_basic (32.67s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 32.692s ```

``` % make testacc TEST=./builtin/providers/aws % TESTARGS='-run=TestAccAWSSubnet_' % 1 ↵ ✹ ✭ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/02/27 19:08:34 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSubnet_ -timeout 120m === RUN TestAccAWSSubnet_importBasic --- PASS: TestAccAWSSubnet_importBasic (69.88s) === RUN TestAccAWSSubnet_basic --- PASS: TestAccAWSSubnet_basic (51.28s) === RUN TestAccAWSSubnet_ipv6 --- PASS: TestAccAWSSubnet_ipv6 (90.39s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws211.574s ```

* provider/aws: Add support for IPV6 enabled VPC ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpc' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/12/09 14:07:31 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpc -timeout 120m === RUN TestAccAWSVpc_importBasic --- PASS: TestAccAWSVpc_importBasic (43.03s) === RUN TestAccAWSVpc_basic --- PASS: TestAccAWSVpc_basic (36.32s) === RUN TestAccAWSVpc_enableIpv6 --- PASS: TestAccAWSVpc_enableIpv6 (29.37s) === RUN TestAccAWSVpc_dedicatedTenancy --- PASS: TestAccAWSVpc_dedicatedTenancy (36.63s) === RUN TestAccAWSVpc_tags --- PASS: TestAccAWSVpc_tags (67.54s) === RUN TestAccAWSVpc_update --- PASS: TestAccAWSVpc_update (66.16s) === RUN TestAccAWSVpc_bothDnsOptionsSet --- PASS: TestAccAWSVpc_bothDnsOptionsSet (16.82s) === RUN TestAccAWSVpc_DisabledDnsSupport --- PASS: TestAccAWSVpc_DisabledDnsSupport (36.52s) === RUN TestAccAWSVpc_classiclinkOptionSet --- PASS: TestAccAWSVpc_classiclinkOptionSet (38.13s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 739.543s ``` * provider/aws: New Resource: aws_egress_only_internet_gateway ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEgressOnlyInternetGateway_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/12/09 14:22:16 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEgressOnlyInternetGateway_ -timeout 120m === RUN TestAccAWSEgressOnlyInternetGateway_basic --- PASS: TestAccAWSEgressOnlyInternetGateway_basic (32.67s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 32.692s ``` * provider/aws: Add IPV6 support to aws_subnet ``` % make testacc TEST=./builtin/providers/aws % TESTARGS='-run=TestAccAWSSubnet_' % 1 ↵ ✹ ✭ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/02/27 19:08:34 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSubnet_ -timeout 120m === RUN TestAccAWSSubnet_importBasic --- PASS: TestAccAWSSubnet_importBasic (69.88s) === RUN TestAccAWSSubnet_basic --- PASS: TestAccAWSSubnet_basic (51.28s) === RUN TestAccAWSSubnet_ipv6 --- PASS: TestAccAWSSubnet_ipv6 (90.39s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws211.574s ``` * provider/aws: Add support for running aws_instances with ipv6 addresses

rfletcher · 2017-03-03T14:36:57Z

I've just run terraform plan for the first time with 0.8.8 and all EC2 Classic aws_instance resources created with an earlier version now show this line in the plan:

ipv6_addresses.#:  "" => "<computed>" (forces new resource)

What's the best way to keep these instances from being destroyed?

rfletcher · 2017-03-03T14:46:19Z

Answering my own question, adding this to the aws_instance config did the trick:

ipv6_addresses = []

Maybe there's a missing test case here? I'm happy to provide more details about these instances if needed.

catsby · 2017-03-03T16:03:05Z

Hey @rfletcher - this issue should be fixed with #12385 , and will go out in the next Terraform release. Until then unfortunately your workout is likely needed. I apologize for the hassle here 😦

rfletcher · 2017-03-03T16:04:55Z

Oh that's great, thanks. No worries. Sorry I missed the other PR!

netflash · 2017-03-07T19:12:17Z

Hmm... not sure where to address this...
I had a VPC and this parameter assign_generated_ipv6_cidr_block hasn't been set, so it was false by default. In webui I have added the IPv6 CIDR to the VPC and then, when I have run terraform plan, terraform had shown me, that it's going to recreate the whole VPC and all the dependencies.

-/+ module.vpc-stage.aws_vpc.mod
    assign_generated_ipv6_cidr_block: "false" => "true" (forces new resource)

I got back to webui, removed that CIDR, waited for a while, and then terraform plan had given me no changes.

I assume this parameter could be amended without re-creating the whole VPC.
What is the best place to report this behavior ?

stack72 · 2017-03-08T12:48:01Z

hi @netflash

I am adding this right now

P.

netflash · 2017-03-08T13:32:09Z

Thanks, mate. @stack72

* provider/aws: Add support for IPV6 enabled VPC ``` % make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVpc' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/12/09 14:07:31 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVpc -timeout 120m === RUN TestAccAWSVpc_importBasic --- PASS: TestAccAWSVpc_importBasic (43.03s) === RUN TestAccAWSVpc_basic --- PASS: TestAccAWSVpc_basic (36.32s) === RUN TestAccAWSVpc_enableIpv6 --- PASS: TestAccAWSVpc_enableIpv6 (29.37s) === RUN TestAccAWSVpc_dedicatedTenancy --- PASS: TestAccAWSVpc_dedicatedTenancy (36.63s) === RUN TestAccAWSVpc_tags --- PASS: TestAccAWSVpc_tags (67.54s) === RUN TestAccAWSVpc_update --- PASS: TestAccAWSVpc_update (66.16s) === RUN TestAccAWSVpc_bothDnsOptionsSet --- PASS: TestAccAWSVpc_bothDnsOptionsSet (16.82s) === RUN TestAccAWSVpc_DisabledDnsSupport --- PASS: TestAccAWSVpc_DisabledDnsSupport (36.52s) === RUN TestAccAWSVpc_classiclinkOptionSet --- PASS: TestAccAWSVpc_classiclinkOptionSet (38.13s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 739.543s ``` * provider/aws: New Resource: aws_egress_only_internet_gateway ``` make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEgressOnlyInternetGateway_' ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2016/12/09 14:22:16 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEgressOnlyInternetGateway_ -timeout 120m === RUN TestAccAWSEgressOnlyInternetGateway_basic --- PASS: TestAccAWSEgressOnlyInternetGateway_basic (32.67s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws 32.692s ``` * provider/aws: Add IPV6 support to aws_subnet ``` % make testacc TEST=./builtin/providers/aws % TESTARGS='-run=TestAccAWSSubnet_' % 1 ↵ ✹ ✭ ==> Checking that code complies with gofmt requirements... go generate $(go list ./... | grep -v /terraform/vendor/) 2017/02/27 19:08:34 Generated command/internal_plugin_list.go TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSubnet_ -timeout 120m === RUN TestAccAWSSubnet_importBasic --- PASS: TestAccAWSSubnet_importBasic (69.88s) === RUN TestAccAWSSubnet_basic --- PASS: TestAccAWSSubnet_basic (51.28s) === RUN TestAccAWSSubnet_ipv6 --- PASS: TestAccAWSSubnet_ipv6 (90.39s) PASS ok github.com/hashicorp/terraform/builtin/providers/aws211.574s ``` * provider/aws: Add support for running aws_instances with ipv6 addresses

ghost · 2020-04-16T01:51:53Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

stack72 added enhancement provider/aws labels Dec 5, 2016

apparentlymart reviewed Dec 5, 2016

View reviewed changes

stack72 force-pushed the f-aws-vpc-ipv6 branch 2 times, most recently from d40d498 to 26f2e8c Compare December 9, 2016 14:33

martin-cossy-atwork mentioned this pull request Jan 26, 2017

IPV6 support in AWS VPC #11430

Closed

stack72 force-pushed the f-aws-vpc-ipv6 branch 2 times, most recently from a2f51da to 781420b Compare February 28, 2017 12:35

stack72 force-pushed the f-aws-vpc-ipv6 branch from 781420b to 9ca1f0e Compare February 28, 2017 13:40

stack72 changed the title ~~[WIP] provider/aws: Implement IPV6 Support for ec2 / VPC~~ provider/aws: Implement IPV6 Support for ec2 / VPC Feb 28, 2017

tombuildsstuff reviewed Mar 1, 2017

View reviewed changes

grubernaut approved these changes Mar 1, 2017

View reviewed changes

stack72 added 4 commits March 1, 2017 16:06

provider/aws: Add support for running aws_instances with ipv6 addresses

2b80dd0

stack72 force-pushed the f-aws-vpc-ipv6 branch from 9ca1f0e to 2b80dd0 Compare March 1, 2017 16:08

stack72 merged commit 177400d into master Mar 1, 2017

stack72 deleted the f-aws-vpc-ipv6 branch March 1, 2017 16:17

atyndall mentioned this pull request Mar 8, 2017

IPv6 support in AWS VPC routes / acls #12515

Closed

WolverineFan mentioned this pull request Mar 8, 2017

ipv6_cidr_block missing from data.aws_vpc in Terraform 0.8.8 #12526

Closed

bryanburgers mentioned this pull request Mar 31, 2017

provider/aws: Can't create an aws_instance in a VPC with an auto-generated IPv6 address #13250

Closed

ghost locked and limited conversation to collaborators Apr 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

provider/aws: Implement IPV6 Support for ec2 / VPC #10538

provider/aws: Implement IPV6 Support for ec2 / VPC #10538

stack72 commented Dec 5, 2016 •

edited

Loading

apparentlymart Dec 5, 2016

stack72 Dec 9, 2016

stack72 commented Feb 28, 2017

tombuildsstuff Mar 1, 2017

grubernaut left a comment

rfletcher commented Mar 3, 2017 •

edited

Loading

rfletcher commented Mar 3, 2017 •

edited

Loading

catsby commented Mar 3, 2017

rfletcher commented Mar 3, 2017

netflash commented Mar 7, 2017

stack72 commented Mar 8, 2017

netflash commented Mar 8, 2017

ghost commented Apr 16, 2020

provider/aws: Implement IPV6 Support for ec2 / VPC #10538

provider/aws: Implement IPV6 Support for ec2 / VPC #10538

Conversation

stack72 commented Dec 5, 2016 • edited Loading

apparentlymart Dec 5, 2016

Choose a reason for hiding this comment

stack72 Dec 9, 2016

Choose a reason for hiding this comment

stack72 commented Feb 28, 2017

tombuildsstuff Mar 1, 2017

Choose a reason for hiding this comment

grubernaut left a comment

Choose a reason for hiding this comment

rfletcher commented Mar 3, 2017 • edited Loading

rfletcher commented Mar 3, 2017 • edited Loading

catsby commented Mar 3, 2017

rfletcher commented Mar 3, 2017

netflash commented Mar 7, 2017

stack72 commented Mar 8, 2017

netflash commented Mar 8, 2017

ghost commented Apr 16, 2020

stack72 commented Dec 5, 2016 •

edited

Loading

rfletcher commented Mar 3, 2017 •

edited

Loading

rfletcher commented Mar 3, 2017 •

edited

Loading