provider/azurerm: Auto base64encode virtual_machine custom data #12164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
reviewed
Feb 22, 2017
| @@ -266,7 +266,7 @@ For more information on the different example configurations, please check out t | |||
| * `computer_name` - (Required) Specifies the name of the virtual machine. | |||
| * `admin_username` - (Required) Specifies the name of the administrator account. | |||
| * `admin_password` - (Required) Specifies the password of the administrator account. | |||
| * `custom_data` - (Optional) Specifies a base-64 encoded string of custom data. The base-64 encoded string is decoded to a binary array that is saved as a file on the Virtual Machine. The maximum length of the binary array is 65535 bytes. | |||
| * `custom_data` - (Optional) Specifies a base-64 encoded string of custom data. The base-64 encoded string is decoded to a binary array that is saved as a file on the Virtual Machine. The maximum length of the binary array is 65535 bytes. Terraform will auto base64encode this string for you. | |||
There was a problem hiding this comment.
I think we should update this to be a bit clearer. I recommend:
Specifies custom data to supply to the machine. On linux-based systems, this can be used as a cloud-init script. On other systems, this will be copied as a file on disk. Internally, Terraform will base64 encode this value before sending it to the API. The maximum length of the binary array is 65535 bytes.
stack72
force-pushed
the
b-arm-vm-base64encode-custom_data
branch
from
724135e to
3edfd66
Compare
sethvargo
approved these changes
Feb 22, 2017
stack72
force-pushed
the
b-arm-vm-base64encode-custom_data
branch
from
3edfd66 to
2e9bf33
Compare
Reported by @sethvargo - we auto encode for AWS, we should follow a similar pattern for Azure. In order to escape the double encoding, we check that it's not already encoded before encoding
stack72
force-pushed
the
b-arm-vm-base64encode-custom_data
branch
from
2e9bf33 to
8392cec
Compare
stack72
added a commit
that referenced
this pull request
Feb 22, 2017
Reported by @sethvargo - we auto encode for AWS, we should follow a similar pattern for Azure. In order to escape the double encoding, we check that it's not already encoded before encoding
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @sethvargo - we auto encode for AWS, we should follow a
similar pattern for Azure.
In order to escape the double encoding, we check that it's not already
encoded before encoding