Corrected example Scaleway code, cleared up token confusion #12177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adjustment was made after I spent a few minutes scratching my head, I have done the following: * Updated the 'provider' block in the first example code to be 'token' instead of 'access_key' - Didn't work previously. * Clarified locations of both 'access_key' and 'token' within the Scaleway panel, and appropriate naming. * Removed "empty" section in example block at the bottom, as this fails with an error when attempted. Overall I think this increases readability. I have tested this against my own Scaleway account.
ghost
changed the title
nicolai86
approved these changes
Feb 22, 2017
stack72
pushed a commit
that referenced
this pull request
Feb 22, 2017
The adjustment was made after I spent a few minutes scratching my head, I have done the following: * Updated the 'provider' block in the first example code to be 'token' instead of 'access_key' - Didn't work previously. * Clarified locations of both 'access_key' and 'token' within the Scaleway panel, and appropriate naming. * Removed "empty" section in example block at the bottom, as this fails with an error when attempted. Overall I think this increases readability. I have tested this against my own Scaleway account.
stack72
pushed a commit
that referenced
this pull request
Feb 22, 2017
The adjustment was made after I spent a few minutes scratching my head, I have done the following: * Updated the 'provider' block in the first example code to be 'token' instead of 'access_key' - Didn't work previously. * Clarified locations of both 'access_key' and 'token' within the Scaleway panel, and appropriate naming. * Removed "empty" section in example block at the bottom, as this fails with an error when attempted. Overall I think this increases readability. I have tested this against my own Scaleway account.
catsby
added a commit
that referenced
this pull request
Feb 23, 2017
* master: (499 commits) provider/aws: Fix the panic in ssm_association with parameters (#12215) Setting incident_urgency_rule as optional (#12211) Latest Section (#12151) provider/pagerduty: Import support for service integrations (#12141) command: fix test for new Meta type terraform: InstanceState.Meta is value type interface{} Update CHANGELOG.md flatmap: mark computed list as a computed value in Expand provider/azurerm: Bump AzureRM SDK to v8.0.1-beta (#11866) provider/profitbricks: fmt changes post cherry-pick provider/aws: Add missing SSM Links to documentation nav bar (#12202) update azure_network_interface documentation to say required for ip_configuration (#12185) Profitbricks primary nic fix (#12197) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md provider/aws: Lambda DeadLetterConfig support what was the value of the cluster id which caused the problem Corrected example code, cleared up token confusion (#12177) ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adjustment was made after I spent a few minutes scratching my head, I have done the following:
Overall I think this increases readability. I have tested this against my own Scaleway account.
Tested against terraform version 0.8.7