Hash custom_data in state storage #12214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also switches to helpers for b64.
sethvargo
commented
Feb 23, 2017
| v = base64Encode(v) | ||
| } | ||
|
|
||
| v = base64Encode(v) |
There was a problem hiding this comment.
Helper does this check now
sethvargo
commented
Feb 23, 2017
| data = *osProfile.CustomData | ||
| } | ||
| result["custom_data"] = data | ||
| result["custom_data"] = *osProfile.CustomData |
There was a problem hiding this comment.
This I'm not sure about. I tried this with b64 and non-b64 encoded data, and it worked both times. I'm not sure what this code was attempting to do?
|
Looks awesome @sethvargo This is going to be a 0.9 only feature just incase it causes any upgrade issues ;) |
yanndegat
pushed a commit
to yanndegat/terraform
that referenced
this pull request
Mar 13, 2017
This also switches to helpers for b64.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes custom_data to be hashed in the statefile instead of plain-textified. This reduces the size of the statefile and is more in line with how other providers behave.
This also switches to helpers for b64.
/cc @stack72