Vendor fixes #12236
Merged
Vendor fixes #12236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The containerservice package fell behind the others. Fix the vendor.json file to match the vendored packages.
The github.com/aws/aws-sdk-go/service/configservice package was updated without being reflected in the manifest.
multiple scaleway-cli packages were out of sync, unfortunately this pulled in some other updates.
Update some ssh subpackages to match the top-level commit Update the curve25519 package, and manuallly fix the checksum to include the non-amd64 source.
this is still broken on solaris
github.com/scaleway/scaleway-cli/pkg/utils can be imported because it depends on github.com/moul/gotty-client which can't build on solaris. This requires removing the github.com/scaleway/scaleway-cli/pkg/api/helpers.go file which imports the utils package, and we don't use. Not sure how we'll handle this if the structure of the scaleway package changes and we can't break this import any longer.
govendor pulled these in, not sure why.
jbardin
force-pushed
the
jbardin/vendor
branch
from
31f6165 to
79e13b9
Compare
|
LGTM if everything works :P |
mitchellh
approved these changes
Feb 24, 2017
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the updates here are matching the commits of some sub-packages with those of their parent.
Update the
golang.org/x/crypto/curve25519package, and manually add the generic source that govendor won't add.Manually fix the hashes for the
golang.org/x/crypto/curve25519andgithub.com/scaleway/scaleway-cli/pkg/apipackages sogovendor statuspasses.Make the
govendor statuscheck mandatory in travis.