Check spot instance is running before trying to attach volumes

[bodgit]

Currently, given the following manifest snippet:

resource "aws_spot_instance_request" "spot" {
  ...

  ebs_block_device {
    encrypted = true
    ...
  }
}

According to http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-spot-limits.html the Amazon API does not honour the encryption setting on additional volumes. This could be worked around with something like:

resource "aws_spot_instance_request" "spot" {
  wait_for_fulfillment = true
  ...
}

resource "aws_ebs_volume" "volume" {
  encrypted = true
  ...
}

resource "aws_volume_attachment" "attach" {
  volume_id   = "${aws_ebs_volume.volume.id}"
  instance_id = "${aws_spot_instance_request.spot.spot_instance_id}"
  ...
}

However waiting for the spot request to be fulfilled does not guarantee that the instance is running; quite often it's pending for ~ 30-40 seconds which causes the volume attachment to fail. This PR makes the volume attachment poll the instance API to ensure it's running before attempting to attach and fixes the issue.

I lifted the whole resource.StateChangeConf block from the aws_instance resource rather than write a copy of the same refresh function.

I have to include the following disclaimer to keep my employers legal team happy:

This contribution is provided 'as is' and without any warranty or guarantee of any kind, express or implied, including in relation to its quality, suitability for a particular purpose or non-infringement. To the extent permitted by law, in no event shall the creator of this contribution be liable for any claim, damage or other liability, whether arising in contract, tort or otherwise, arising out of or in connection with this contribution.

[stack72]

Hi @bodgit

Thanks for the work here - this LGTM!

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVolumeAttachment_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/07 16:14:03 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVolumeAttachment_ -timeout 120m
=== RUN   TestAccAWSVolumeAttachment_basic
--- PASS: TestAccAWSVolumeAttachment_basic (131.14s)
=== RUN   TestAccAWSVolumeAttachment_skipDestroy
--- PASS: TestAccAWSVolumeAttachment_skipDestroy (145.10s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	276.266s

Paul

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.