Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper/schema: Rename Timeout resource block to Timeouts #12533

Merged
merged 3 commits into from
Mar 9, 2017

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Mar 8, 2017

Pluralize configuration argument name to better represent that there is
one block for many timeouts. Also adds a timeouts block into the db_instance basic test, just to have them present in an acceptance test.

Example:

resource "example" "name" {
  name = "thing"

  timeout {
    create = "10m"
    update = "5m"
  }
}

Becomes:

resource "example" "name" {
  name = "thing"

  timeouts {
    create = "10m"
    update = "5m"
  }
}

This is a follow up change to the following:

cc @mitchellh


This is intended for v0.9 only, as Timeouts were not back ported to v0.8.x series

Pluralize configuration argument name to better represent that there is
one block for many timeouts
@catsby catsby added the core label Mar 8, 2017
@catsby catsby requested a review from mitchellh March 8, 2017 17:40
@mitchellh
Copy link
Contributor

May want to consider making the key a constant in the file. :)

@catsby catsby merged commit 3fdeacd into master Mar 9, 2017
@catsby catsby deleted the f-helper-schema-timouts-rename branch March 9, 2017 20:40
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
…2533)

helper/schema: Rename Timeout resource block to Timeouts

- Pluralize configuration argument name to better represent that there is
one block for many timeouts
- use a const for the configuration timeouts key
- update docs
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants