Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add address, port, hosted_zone_id and endpoint for aws_db_instance datasource #12623

Merged
merged 2 commits into from
Mar 13, 2017
Merged

provider/aws: Add address, port, hosted_zone_id and endpoint for aws_db_instance datasource #12623

merged 2 commits into from
Mar 13, 2017

Conversation

lucasvasconcelos
Copy link
Contributor

  • The address and hosted_zone_id can be used in a route53_record
  • The port and the endpoint can be used to provide information when bootstrapping apps.
make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSDataDbInstance_endpoint'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/12 19:04:37 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws/ -v -run=TestAccAWSDataDbInstance_endpoint -timeout 120m
=== RUN   TestAccAWSDataDbInstance_endpoint
--- PASS: TestAccAWSDataDbInstance_endpoint (579.47s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	579.491s

@stack72
Copy link
Contributor

stack72 commented Mar 13, 2017

LGTM thanks for this :)

@stack72 stack72 merged commit 1a957a0 into hashicorp:master Mar 13, 2017
stack72 pushed a commit that referenced this pull request Mar 13, 2017
…db_instance datasource (#12623)

* Add address, port, hosted_zone_id and endpoint information to datasource aws_db_instance

* Update the docs
yanndegat pushed a commit to yanndegat/terraform that referenced this pull request Mar 13, 2017
…db_instance datasource (hashicorp#12623)

* Add address, port, hosted_zone_id and endpoint information to datasource aws_db_instance

* Update the docs
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants