Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Added conflictsWith for API GW Domain Name certificate_arn #12649

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

Ninir
Copy link
Contributor

@Ninir Ninir commented Mar 13, 2017

Description

This follows #12592 (comment) to add the ConflictsWith attribute, since you can only choose to have your certificate or an ACM one.

Tests

$ make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSAPIGatewayDomainName_' 
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/03/13 15:59:40 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSAPIGatewayDomainName_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayDomainName_basic
--- PASS: TestAccAWSAPIGatewayDomainName_basic (62.44s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	62.544s

@stack72
Copy link
Contributor

stack72 commented Mar 13, 2017

LGTM!

@stack72 stack72 merged commit cdc3fa8 into hashicorp:master Mar 13, 2017
@Ninir Ninir deleted the f-aws-apigw-domainname branch March 13, 2017 17:59
@ghost
Copy link

ghost commented Apr 15, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants