Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/openstack: Resolve issues with Port Fixed IPs #13056

Merged
merged 2 commits into from
Mar 27, 2017

Commits on Mar 25, 2017

  1. provider/openstack: Add all_fixed_ips computed attribute to port reso…

    …urce
    
    This commit adds the `all_fixed_ips` attribute to the
    openstack_networking_port_v2 resource. This contains all of the port's
    Fixed IPs returned by the Networking v2 API.
    jtopjian committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    022b324 View commit details
    Browse the repository at this point in the history
  2. provider/openstack: Revert Port fixed_ip back to a List

    This commit reverts the changes made in a8c4e81. This
    re-enables the ability to reference IP addresses using the
    numerical-element notation.
    
    This commit also makes fixed_ip a non-computed field, meaning
    Terraform will no longer set fixed_ip with what was returned
    by the API. This resolves the original issue about ordering.
    
    The last use-case is for fixed_ips that received an IP address
    via DHCP. Because fixed_ip is no longer computed, the DHCP IP
    will not be set. The workaround for this use-case is to use the
    new all_fixed_ips attribute.
    
    In effect, users should use fixed_ip only as a way of inputting
    data into Terraform and use all_fixed_ips as the output returned
    by the API. If use-cases exist where fixed_ip can be used as an
    output, that's a bonus feature.
    jtopjian committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    3d60e11 View commit details
    Browse the repository at this point in the history