provider/ns1: No splitting answer on spf records.

[pashap]

References #12758

Previously, provider was incorrectly splitting spf answers by spaces.

Tested via host -t SPF terraform.example dns1.p03.nsone.net and received the expected output

[radeksimko]

Hi @pashap
thanks for submitting the PR.

Would you mind attaching an acceptance test too? The test would normally go into builtin/providers/ns1/resource_record_test.go - It should be fairly easy to take one of the existing tests and modify according to our needs here for this bugfix, but let me know if you need further help in that area.

Checking the API response struct (via testAccCheckRecordAnswerRdata) and/or state (via resource.TestCheckResourceAttr) is sufficient - i.e. we don't need to wait for the DNS record to propagate nor use the DNS protocol in this context generally.

[pashap]

Hi @radeksimko, thanks for pointing that out. Ill avoid PRs in the future without acceptance tests, they are very easy to write in terraform :)

I just pushed a commit with the SPF record acc test, please let me know if it looks good whenever you get a chance

[radeksimko]

LGTM. Thanks for adding the test.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.