-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lock timeouts #13262
lock timeouts #13262
Commits on Apr 1, 2017
-
Since moving to the new backends, all states (except InmemState) are Lockers. Add the methods to the State interface to remove a heap of assertion checks.
Configuration menu - View commit details
-
Copy full SHA for bf6384a - Browse repository at this point
Copy the full SHA bf6384aView commit details -
remove extra state.Locker assertions
All states are lockers, so get rid of extra asertions.
Configuration menu - View commit details
-
Copy full SHA for 75458a1 - Browse repository at this point
Copy the full SHA 75458a1View commit details -
LockWithContext will retry a lock until the context expires or is cancelled. This will let us implement a `-lock-timeout` flag, and make use of existing contexts when applicable.
Configuration menu - View commit details
-
Copy full SHA for 826771a - Browse repository at this point
Copy the full SHA 826771aView commit details -
Have the clistate Lock use LockWithContext
- Have the ui Lock helper use state.LockWithContext. - Rename the message package to clistate, since that's how it's imported everywhere. - Use a more idiomatic placement of the Context in the LockWithContext args.
Configuration menu - View commit details
-
Copy full SHA for 3f0dcd1 - Browse repository at this point
Copy the full SHA 3f0dcd1View commit details -
provide contexts to clistate.Lock calls
Add fields required to create an appropriate context for all calls to clistate.Lock. Add missing checks for Meta.stateLock, where we would attempt to lock, even if locking should be skipped.
Configuration menu - View commit details
-
Copy full SHA for 305ef43 - Browse repository at this point
Copy the full SHA 305ef43View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e9d0b1 - Browse repository at this point
Copy the full SHA 9e9d0b1View commit details -
add cli flags for -lock-timeout
Add the -lock-timeout flag to the appropriate commands. Add the -lock flag to `init` and `import` which were missing it. Set both stateLock and stateLockTimeout in Meta.flagsSet, and remove the extra references for clarity.
Configuration menu - View commit details
-
Copy full SHA for 5eca913 - Browse repository at this point
Copy the full SHA 5eca913View commit details -
give LockWithContext a little backoff
Backoff the Lock calls exponentially, to a reasonable limit.
Configuration menu - View commit details
-
Copy full SHA for 93b1dd6 - Browse repository at this point
Copy the full SHA 93b1dd6View commit details
Commits on Apr 3, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d1460d8 - Browse repository at this point
Copy the full SHA d1460d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3d60485 - Browse repository at this point
Copy the full SHA 3d60485View commit details -
Configuration menu - View commit details
-
Copy full SHA for af2e289 - Browse repository at this point
Copy the full SHA af2e289View commit details
Commits on Apr 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7cfb515 - Browse repository at this point
Copy the full SHA 7cfb515View commit details