provider/aws: Add non-destructive updates to AWS RDS #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* f-aws-rds-tags: fix index out of range error fix formatting upgrade VPC Ids and DB Subnet to be optionally computed fix typo provider/aws: Introduce IAM connection
This introduces non-destructive, in-place upgrades to MultiAZ and Engine Version attributes of AWS RDS instances.
|
LGTM |
* master: (167 commits) return error if failed to set tags on Route 53 zone core: [tests] fix order dependent test Fix hashcode for ASG test provider/aws: Fix issue with tainted ASG groups failing to re-create Don't error when reading s3 bucket with no tags Avoid panics when DBName is not set Add floating IP association in aceptance tests Use env var OS_POOL_NAME as default for pool attribute providers/heroku: Add heroku-postgres to example docs: resource addressing providers/heroku: Document environment variables providers/heroku: Add region to example Bugfix on floating IP assignment Update CHANGELOG.md update CHANGELOG website: note on docker core: formalize resource addressing core: fill out context tests for targeted ops core: docs for targeted operations core: targeted operations ...
catsby
added a commit
that referenced
this pull request
Apr 1, 2015
provider/aws: Add non-destructive updates to AWS RDS
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a spike at introducing in-place updates of AWS RDS instances, without destroying and re-creating the entire instance, currently only supporting
engine_versionandmulti_azas proof of concept.RDS has a concept of
apply_immediatelyfor each modification request, detailed here:TL;DR:
apply_immediately = truewill introduce downtime immediately,falsewill apply the changes in the next maintenance window. The caveat there is that the local state won't be updated until after the change, soterraform planwill continue to show a pending update until after the change is applied.There are several other attributes we can modify without destroying the instance, listed here:
I'm sending this as is for feedback before implementing the remaining items. This should fix #1070, #1278, and #1140