provider/aws: Fix issue with tainted ASG groups failing to re-create #1353
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto Scaling groups can take a minute or two to fully delete even after being drained. In the case of recreating them (ex. a tainted ASG), the immediate re-create attempt will fail because the original still exists, and the new one violates a name constraint.
This PR fixes #1105 by waiting on the ASG to fully delete before returning from the
resourceAwsAutoscalingGroupDelete
function. The timeout is set at 5 minutes, but in practice it's usually less than 1 minute.