Provider Oneandone #13633

jasmingacic · 2017-04-13T18:06:44Z

This is a provider for 1&1.
Cloud Server API documentation is here

This provider manages following 1&1 resources:

Server
Firewall Policy
Monitoring Policy
Shared Storage
Load Balancer
Private Networks
VPN
Public IP

For credentials for acceptance tests please contact me on via email.

stack72

Hi @jasminSPC

Ran through the first couple of resources and found the same issues in both

Can you have a look and see if you can roll the same changes across all of the resources?

Thanks

Paul

stack72 · 2017-04-18T14:13:21Z

builtin/providers/oneandone/provider.go

+				Optional: true,
+				Default:  50,
+			},
+			"endpoint": {


I think it would be good to be able to allow this to be set via ENV VAR as well

stack72 · 2017-04-18T14:13:34Z

builtin/providers/oneandone/provider.go

+			"retries": {
+				Type:     schema.TypeInt,
+				Optional: true,
+				Default:  50,


Also ENV VAR would be a good addition

stack72 · 2017-04-18T14:14:39Z

builtin/providers/oneandone/provider.go

+	}
+	config := Config{
+		Token:    d.Get("token").(string),
+		Retries:  d.Get("retries").(int),


Retries are passed to the Config struct but not actually used in there?

"retries" are not used in provider.go but are used pretty much in every 1and1 resource.

stack72 · 2017-04-18T14:17:05Z

builtin/providers/oneandone/resource_oneandone_firewall_policy.go

+						"port_from": {
+							Type:     schema.TypeInt,
+							Optional: true,
+							ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) {


There is a new func that you can use as part of the helpers package:

validation.IntBetween(1, 65535),

it lives in the github.com/hashicorp/terraform/helper/validation package

stack72 · 2017-04-18T14:17:54Z

builtin/providers/oneandone/resource_oneandone_firewall_policy.go

+		return err
+	}
+
+	config.API.WaitForState(fw, "ACTIVE", 10, config.Retries)


You are waiting for state twice

stack72 · 2017-04-18T14:26:15Z

builtin/providers/oneandone/resource_oneandone_loadbalancer.go

+	}
+
+	if raw, ok := d.GetOk("persistence"); ok {
+		req.Persistence = oneandone.Bool2Pointer(raw.(bool))


love the wrappers :)

Should I remove it?

stack72 · 2017-04-18T14:27:09Z

builtin/providers/oneandone/resource_oneandone_loadbalancer.go

+func resourceOneandOneLoadbalancerUpdate(d *schema.ResourceData, meta interface{}) error {
+	config := meta.(*Config)
+
+	if d.HasChange("name") || d.HasChange("description") || d.HasChange("method") || d.HasChange("persistence") || d.HasChange("persistence_time") || d.HasChange("health_check_test") || d.HasChange("healt_check_interval") {


typo on health_check_interval

stack72 · 2017-04-18T14:28:22Z

builtin/providers/oneandone/resource_oneandone_loadbalancer.go

+		oldR, newR := d.GetChange("rules")
+		oldValues := oldR.([]interface{})
+		newValues := newR.([]interface{})
+		if len(oldValues) > len(newValues) {


Again questioning if this is valid logic...

Added acceptance test for the scenario

stack72 · 2017-04-18T14:29:30Z

builtin/providers/oneandone/resource_oneandone_loadbalancer_test.go

+	"time"
+)
+
+func TestAccOneandoneLoadbalancer_Basic(t *testing.T) {


Would love to see a test for Import

Import is not implemented

I removed ImportStatePassthrough

stack72 · 2017-04-18T14:30:35Z

builtin/providers/oneandone/resource_oneandone_loadbalancer.go

+				Type:     schema.TypeString,
+				Optional: true,
+			},
+			"method": {


Do we need to check the valid values or the casing of this?

Added validation for two known methods

jasmingacic · 2017-04-19T21:17:40Z

Hi @stack72 ,

I've addressed all remarks as requested

stack72 · 2017-04-20T18:32:21Z

This test: TestAccOneandonePrivateNetwork_Basic doesn't finish for me - has been running for like 30 mins

Also, the website doesn't have the link to the provider docs

jasmingacic · 2017-04-20T19:11:20Z

Here are the docs https://cloudpanel-api.1and1.com/documentation/v1/en/documentation.html
As for the test I'll get back to you

jasmingacic · 2017-04-20T20:03:03Z

@stack72 I was able to speed it up a little by using different server image

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/20 21:45:01 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/oneandone/ -v -run=TestAccOneandonePrivateNetwork_Basic -timeout 120m
=== RUN   TestAccOneandonePrivateNetwork_Basic
--- PASS: TestAccOneandonePrivateNetwork_Basic (898.95s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/oneandone      898.961s

I'm going to push the changes

jasmingacic · 2017-04-20T21:38:26Z

==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/20 23:11:15 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/oneandone/ -v  -timeout 120m
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccOneandoneFirewall_Basic
--- PASS: TestAccOneandoneFirewall_Basic (58.00s)
=== RUN   TestAccOneandoneLoadbalancer_Basic
--- PASS: TestAccOneandoneLoadbalancer_Basic (140.70s)
=== RUN   TestAccOneandoneMonitoringPolicy_Basic
--- PASS: TestAccOneandoneMonitoringPolicy_Basic (28.18s)
=== RUN   TestAccOneandonePrivateNetwork_Basic
--- PASS: TestAccOneandonePrivateNetwork_Basic (868.68s)
=== RUN   TestAccOneandonePublicIp_Basic
--- PASS: TestAccOneandonePublicIp_Basic (43.53s)
=== RUN   TestAccOneandoneServer_Basic
--- PASS: TestAccOneandoneServer_Basic (233.72s)
=== RUN   TestAccOneandoneVpn_Basic
--- PASS: TestAccOneandoneVpn_Basic (110.39s)
=== RUN   TestAccOneandoneSharedStorage_Basic
--- PASS: TestAccOneandoneSharedStorage_Basic (60.77s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/oneandone      1543.995s```

stack72 · 2017-04-21T14:18:59Z

One test issue that @jasminSPC is working on but this is good to go! I am going to merge and he is going to follow up with a test fix

Paul

jasmingacic · 2017-04-21T15:49:34Z

Fixed
https://ci.hashicorp.engineering/viewLog.html?buildId=34346&tab=buildResultsDiv&buildTypeId=Terraform_ProviderOneOne

ghost · 2020-04-08T01:55:39Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

jasminSPC added 2 commits April 13, 2017 19:58

Terraform Provider 1&1

8569766

Merge remote-tracking branch 'upstream/master' into oneandone

5d9f06c

jasmingacic added enhancement new-provider labels Apr 13, 2017

stack72 suggested changes Apr 18, 2017

View reviewed changes

jasminSPC added 3 commits April 18, 2017 23:23

Addressing pull request remarks

fec36f9

Fixed imports

d9d2c1d

Fixing remarks

1bf8a5d

jasminSPC added 2 commits April 20, 2017 22:55

Test optimiziation

5dd848f

Merge remote-tracking branch 'upstream/master' into oneandone

d6d3477

stack72 merged commit 61499cf into hashicorp:master Apr 21, 2017

jasmingacic deleted the oneandone branch August 2, 2017 21:02

ghost locked and limited conversation to collaborators Apr 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provider Oneandone #13633

Provider Oneandone #13633

jasmingacic commented Apr 13, 2017

stack72 left a comment

stack72 Apr 18, 2017

stack72 Apr 18, 2017

stack72 Apr 18, 2017

jasmingacic Apr 18, 2017 •

edited

Loading

stack72 Apr 18, 2017

stack72 Apr 18, 2017

stack72 Apr 18, 2017

jasmingacic Apr 18, 2017

stack72 Apr 18, 2017

stack72 Apr 18, 2017

jasmingacic Apr 18, 2017

stack72 Apr 18, 2017

jasmingacic Apr 18, 2017

jasmingacic Apr 18, 2017

stack72 Apr 18, 2017

jasmingacic Apr 18, 2017

jasmingacic commented Apr 19, 2017

stack72 commented Apr 20, 2017

jasmingacic commented Apr 20, 2017

jasmingacic commented Apr 20, 2017

jasmingacic commented Apr 20, 2017

stack72 commented Apr 21, 2017

jasmingacic commented Apr 21, 2017

ghost commented Apr 8, 2020

Provider Oneandone #13633

Provider Oneandone #13633

Conversation

jasmingacic commented Apr 13, 2017

stack72 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasmingacic Apr 18, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jasmingacic commented Apr 19, 2017

stack72 commented Apr 20, 2017

jasmingacic commented Apr 20, 2017

jasmingacic commented Apr 20, 2017

jasmingacic commented Apr 20, 2017

stack72 commented Apr 21, 2017

jasmingacic commented Apr 21, 2017

ghost commented Apr 8, 2020

jasmingacic Apr 18, 2017 •

edited

Loading