Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: AWS WAF Regional ByteMatchSet support #13703

Closed

Conversation

yusukegoto
Copy link
Contributor

@yusukegoto yusukegoto commented Apr 17, 2017

This PR is start point which is from #13676.

test

resource "aws_wafregional_byte_match_set" "byte_set" {
  name = "tf_waf_byte_match_set"
  byte_match_tuples {
    text_transformation = "NONE"
    target_string = "badrefer1"
    positional_constraint = "CONTAINS"
    field_to_match {
      type = "HEADER"
      data = "referer"
    }   
  }
}

exec

aws_wafregional_byte_match_set.byte_set: Creating...
  byte_match_tuples.#:                                         "" => "1"
  byte_match_tuples.2174619346.field_to_match.#:               "" => "1"
  byte_match_tuples.2174619346.field_to_match.2991901334.data: "" => "referer"
  byte_match_tuples.2174619346.field_to_match.2991901334.type: "" => "HEADER"
  byte_match_tuples.2174619346.positional_constraint:          "" => "CONTAINS"
  byte_match_tuples.2174619346.target_string:                  "" => "badrefer1"
  byte_match_tuples.2174619346.text_transformation:            "" => "NONE"
  name:                                                        "" => "tf_waf_byte_match_set"
aws_wafregional_byte_match_set.byte_set: Creation complete (ID: 2b03fa02-7b9e-4560-bb91-3d2746bf41c1)

@radeksimko
Copy link
Member

I noticed you included this resource in #13705 - which is 👌 as two resources are still easier to review than 7 😅

Shall we close this PR then?

@radeksimko radeksimko added enhancement new-resource provider/aws waiting-response An issue/pull request is waiting for a response from the community labels Apr 18, 2017
@yusukegoto
Copy link
Contributor Author

@radeksimko OK! Close this!

@radeksimko radeksimko closed this Apr 18, 2017
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants