Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add test for SNS subscription w/ autoconfirming endpoint #13912

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

radeksimko
Copy link
Member

Related discussion in #9696 (comment)

Test plan

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSNSTopicSubscription_'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/04/24 21:18:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSNSTopicSubscription_ -timeout 120m
=== RUN   TestAccAWSSNSTopicSubscription_importBasic
--- PASS: TestAccAWSSNSTopicSubscription_importBasic (79.53s)
=== RUN   TestAccAWSSNSTopicSubscription_basic
--- PASS: TestAccAWSSNSTopicSubscription_basic (54.58s)
=== RUN   TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint
--- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (137.69s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	271.826s

cc @Ninir

@Ninir
Copy link
Contributor

Ninir commented Apr 25, 2017

Hey @radeksimko,

Thanks for this :)

Do you think we could version the content of the zip file, and basically create the zip file based on it using the archive data source?

@radeksimko
Copy link
Member Author

I thought about that idea too, but I wanted to avoid spanning the test cross providers and keep it isolated. i.e. I don't want this test to fail just because archive provider becomes broken.

@radeksimko radeksimko merged commit eb374b7 into master Apr 25, 2017
@radeksimko radeksimko deleted the test-aws-sns-subs-autoconfirm branch April 25, 2017 20:25
@ghost
Copy link

ghost commented Apr 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants