Allows zero-value ELB and ALB names

[gdavison]

The aws_alb and aws_elb resources did not allow zero-value name fields.

[grubernaut]

Hey @gdavison, thanks for the contribution!

I'm not quite sure, however, what this PR aims to solve. The name parameter is already an Optional and Computed attribute, so if the aws_alb resource is created without the name attribute specified, one will be generated. (Same applies to the aws_elb resource).

Is there a use-case for explicitly setting the name attribute to a nil string, instead of omitting the attribute?

Thanks!

[gdavison]

@grubernaut Sometimes when the aws_alb resource is created a generic name is ok, but other times, we may want a specific name. Allowing the zero-value field, i.e. an empty string, lets the user defer the decision or make it conditional.

variable "alb_name" {
  default = ""
}

resource "aws_alb" "sample_alb" {
  name = "${var.alb_name}"
 ...
}

This currently fails with the message "aws_alb. sample_alb: only alphanumeric characters and hyphens allowed in "name""

[gdavison]

Also, @mitchellh's comment on #5471

Most resources at the moment must just be written to accept some "zero" value as unset. If a resource doesn't support this please report a bug.

[grubernaut]

@gdavison, perfect, thanks!

[grubernaut]

LGTM, thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.