Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/google: stop trying to set mysqlReplicaConfiguration on read #14373

Merged
merged 1 commit into from
May 22, 2017

Conversation

danawillow
Copy link
Contributor

This is branched off of #14336, so that should be reviewed first.

Fixes #11651.

Even though it's part of the API, mysqlReplicaConfiguration is never returned on read. The documentation notes:

MySQL specific configuration when replicating from a MySQL on-premises master. Replication configuration information such as the username, password, certificates, and keys are not stored in the instance metadata. The configuration information is used only to set up the replication connection and is stored by MySQL in a file named master.info in the data directory.

Because it isn't returned on read, trying to read after setting it on create would crash every time. This fixes that crash.

This change also sets MaxItems: 1 on replica_configuration and removes read-time checks that it only has 1 item.

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the prerequisite PR

@danawillow danawillow merged commit 5d05b0b into hashicorp:master May 22, 2017
@danawillow danawillow deleted the is-11651 branch May 31, 2017 16:10
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash creating Google Cloud SQL 2nd Generation replication instance
3 participants