Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for joining domain for resource db_instance #14425

Closed
wants to merge 2 commits into from

Conversation

mikewalker125
Copy link

This will resolve #13329.

Adds domain and domain-iam-role-name parameters to resource aws_db_instance.

@nckslvrmn
Copy link

Bump +1, This is a critical feature I would love to start using ASAP.

@paddycarver
Copy link
Contributor

paddycarver commented Jul 25, 2017

As mentioned in the issue for this (#13329 (comment)), development has moved to the aws provider repository, so we'd have to close this PR and re-open it against that repo. If @mikewalker125 is interested in doing that, just comment here or go ahead and open the PR (preferably linking back here so the two get connected). If I haven't heard anything within a few days, I'll go ahead and migrate it myself, doing my best to preserve git authorship info, and take over shepherding the PR through review.

Sorry for the inconvenience!

@paddycarver
Copy link
Contributor

This is now hashicorp/terraform-provider-aws#1363. Thanks @nckslvrmn!

@ghost
Copy link

ghost commented Apr 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants