provider/aws: ForceNew aws_launch_config when root_block_device changes

builtin/providers/aws/resource_aws_launch_configuration.go

@@ -28,7 +28,7 @@ func resourceAwsLaunchConfiguration() *schema.Resource {
  },
 
  Schema: map[string]*schema.Schema{
- "name": &schema.Schema{
+ "name": {
  Type: schema.TypeString,
  Optional: true,
  Computed: true,
@@ -45,7 +45,7 @@ func resourceAwsLaunchConfiguration() *schema.Resource {
  },
  },
 
- "name_prefix": &schema.Schema{
+ "name_prefix": {
  Type: schema.TypeString,
  Optional: true,
  ForceNew: true,
@@ -61,32 +61,32 @@ func resourceAwsLaunchConfiguration() *schema.Resource {
  },
  },
 
- "image_id": &schema.Schema{
+ "image_id": {
  Type: schema.TypeString,
  Required: true,
  ForceNew: true,
  },
 
- "instance_type": &schema.Schema{
+ "instance_type": {
  Type: schema.TypeString,
  Required: true,
  ForceNew: true,
  },
 
- "iam_instance_profile": &schema.Schema{
+ "iam_instance_profile": {
  Type: schema.TypeString,
  Optional: true,
  ForceNew: true,
  },
 
- "key_name": &schema.Schema{
+ "key_name": {
  Type: schema.TypeString,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "user_data": &schema.Schema{
+ "user_data": {
  Type: schema.TypeString,
  Optional: true,
  ForceNew: true,
@@ -101,109 +101,109 @@ func resourceAwsLaunchConfiguration() *schema.Resource {
  },
  },
 
- "security_groups": &schema.Schema{
+ "security_groups": {
  Type: schema.TypeSet,
  Optional: true,
  ForceNew: true,
  Elem: &schema.Schema{Type: schema.TypeString},
  Set: schema.HashString,
  },
 
- "vpc_classic_link_id": &schema.Schema{
+ "vpc_classic_link_id": {
  Type: schema.TypeString,
  Optional: true,
  ForceNew: true,
  },
 
- "vpc_classic_link_security_groups": &schema.Schema{
+ "vpc_classic_link_security_groups": {
  Type: schema.TypeSet,
  Optional: true,
  ForceNew: true,
  Elem: &schema.Schema{Type: schema.TypeString},
  Set: schema.HashString,
  },
 
- "associate_public_ip_address": &schema.Schema{
+ "associate_public_ip_address": {
  Type: schema.TypeBool,
  Optional: true,
  ForceNew: true,
  Default: false,
  },
 
- "spot_price": &schema.Schema{
+ "spot_price": {
  Type: schema.TypeString,
  Optional: true,
  ForceNew: true,
  },
 
- "ebs_optimized": &schema.Schema{
+ "ebs_optimized": {
  Type: schema.TypeBool,
  Optional: true,
  ForceNew: true,
  Computed: true,
  },
 
- "placement_tenancy": &schema.Schema{
+ "placement_tenancy": {
  Type: schema.TypeString,
  Optional: true,
  ForceNew: true,
  },
 
- "enable_monitoring": &schema.Schema{
+ "enable_monitoring": {
  Type: schema.TypeBool,
  Optional: true,
  ForceNew: true,
  Default: true,
  },
 
- "ebs_block_device": &schema.Schema{
+ "ebs_block_device": {
  Type: schema.TypeSet,
  Optional: true,
  Computed: true,
  Elem: &schema.Resource{
  Schema: map[string]*schema.Schema{
- "delete_on_termination": &schema.Schema{
+ "delete_on_termination": {
  Type: schema.TypeBool,
  Optional: true,
  Default: true,
  ForceNew: true,
  },
 
- "device_name": &schema.Schema{
+ "device_name": {
  Type: schema.TypeString,
  Required: true,
  ForceNew: true,
  },
 
- "iops": &schema.Schema{
+ "iops": {
  Type: schema.TypeInt,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "snapshot_id": &schema.Schema{
+ "snapshot_id": {
  Type: schema.TypeString,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "volume_size": &schema.Schema{
+ "volume_size": {
  Type: schema.TypeInt,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "volume_type": &schema.Schema{
+ "volume_type": {
  Type: schema.TypeString,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "encrypted": &schema.Schema{
+ "encrypted": {
  Type: schema.TypeBool,
  Optional: true,
  Computed: true,
@@ -220,18 +220,18 @@ func resourceAwsLaunchConfiguration() *schema.Resource {
  },
  },
 
- "ephemeral_block_device": &schema.Schema{
+ "ephemeral_block_device": {
  Type: schema.TypeSet,
  Optional: true,
  ForceNew: true,
  Elem: &schema.Resource{
  Schema: map[string]*schema.Schema{
- "device_name": &schema.Schema{
+ "device_name": {
  Type: schema.TypeString,
  Required: true,
  },
 
- "virtual_name": &schema.Schema{
+ "virtual_name": {
  Type: schema.TypeString,
  Required: true,
  },
@@ -246,52 +246,45 @@ func resourceAwsLaunchConfiguration() *schema.Resource {
  },
  },
 
- "root_block_device": &schema.Schema{
- // TODO: This is a set because we don't support singleton
- // sub-resources today. We'll enforce that the set only ever has
- // length zero or one below. When TF gains support for
- // sub-resources this can be converted.
- Type: schema.TypeSet,
+ "root_block_device": {
+ Type: schema.TypeList,
  Optional: true,
  Computed: true,
+ MaxItems: 1,
  Elem: &schema.Resource{
  // "You can only modify the volume size, volume type, and Delete on
  // Termination flag on the block device mapping entry for the root
  // device volume." - bit.ly/ec2bdmap
  Schema: map[string]*schema.Schema{
- "delete_on_termination": &schema.Schema{
+ "delete_on_termination": {
  Type: schema.TypeBool,
  Optional: true,
  Default: true,
  ForceNew: true,
  },
 
- "iops": &schema.Schema{
+ "iops": {
  Type: schema.TypeInt,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "volume_size": &schema.Schema{
+ "volume_size": {
  Type: schema.TypeInt,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
 
- "volume_type": &schema.Schema{
+ "volume_type": {
  Type: schema.TypeString,
  Optional: true,
  Computed: true,
  ForceNew: true,
  },
  },
  },
- Set: func(v interface{}) int {
- // there can be only one root device; no need to hash anything
- return 0
- },
  },
  },
  }
@@ -416,10 +409,7 @@ func resourceAwsLaunchConfigurationCreate(d *schema.ResourceData, meta interface
  }
 
  if v, ok := d.GetOk("root_block_device"); ok {
- vL := v.(*schema.Set).List()
- if len(vL) > 1 {
- return fmt.Errorf("Cannot specify more than one root_block_device.")
- }
+ vL := v.([]interface{})
  for _, v := range vL {
  bd := v.(map[string]interface{})
  ebs := &autoscaling.Ebs{