-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provider/aws: Handle LimitExceededException for subscriber limits #14571
Conversation
- Updates aws-sdk-go/request for retryer fix - Fixes dynamoDB exception handling to catch subscriber limit error When the `aws-sdk-go` dep releases the next release, we can tag the vendor with the new release version, and merge this. Until then, soft-updated the vendor solely for the `request` package to post fix. DynamoDB Fix: ``` aws_dynamodb_table.bar: Creating... arn: "" => "<computed>" attribute.#: "" => "1" attribute.4228504427.name: "" => "id" attribute.4228504427.type: "" => "S" hash_key: "" => "id" name: "" => "over-cap-test" read_capacity: "" => "5" stream_arn: "" => "<computed>" stream_enabled: "" => "<computed>" stream_view_type: "" => "<computed>" write_capacity: "" => "5" Error applying plan: 1 error(s) occurred: * aws_dynamodb_table.bar: 1 error(s) occurred: * aws_dynamodb_table.bar: AWS Error creating DynamoDB table: LimitExceededException: Subscriber limit exceeded: There is a limit of 256 tables per subscriber status code: 400, request id: J2MC7MR060VKBPHP9P6JG5B6Q3VV4KQNSO5AEMVJF66Q9ASUAAJG ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Love the removal of the if / else :)
This won't be merged until the next AWS tagged SDK release |
@grubernaut a new version of the SDK has been released :) |
LGTM! Nice one :) |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
When the
aws-sdk-go
dep releases the next release, we can tag the vendor with the newrelease version, and merge this. Until then, soft-updated the vendor solely for the
request
package to post fix.aws-sdk-go
was patched from this issue: aws/aws-sdk-go#1271DynamoDB Fix:
The open issues, with the exception of the DynamoDB issue, don't check for the
LimitExceededException
error code, and should now fail accurately with the appropriate error message.Fixes: #13339, #13802, #11143, #11654