check for IsComputed when validating a schema object #14801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH-14784 allowed nested structures to be validate, rather than relying on the raw value. However this still returns the same validation error if the structures contain a computed value, since Get will return the raw string in that case. This simply skips the validation in the IsComputed case, since there's nothing that can be checked.
|
@mattrobenolt, thanks for the initial PR! |
|
Ah, I see what I did wrong. :) Thanks for the carry! ❤️ |
apparentlymart
approved these changes
May 24, 2017
There was a problem hiding this comment.
Looks good to me!
This will probably cause certain errors to move to the apply phase, but they can't have been doing anything useful during the plan phase anyway (since they where just the unknown variable value) so no worse than we had before, and not much else we can do for that situation anyway.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH-14784 allowed nested structures to be validated, rather than relying
on the raw value. However this still returns the same validation error
if the structures contain a computed value, since Get will return the
raw string in that case.
This simply skips the validation in the IsComputed case, since there's
nothing that can be checked.