provider/google: Update google_compute_target_pool's session_affinity default

[rileykarson]

Update the session_affinity field to have a default set, like our documentation suggests. The API also has this value - right now, Terraform recreates target pools on every apply.

This can be seen with this configuration:

resource "google_compute_target_pool" "target-pool" {
  name = "tf-target-pool"
}

followed by:

terraform apply
terraform apply

This should stop the creation of a new resource in #14770.

@danawillow

[danawillow]

TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeTargetPool -timeout 120m
=== RUN   TestAccComputeTargetPool_importBasic
--- PASS: TestAccComputeTargetPool_importBasic (45.95s)
=== RUN   TestAccComputeTargetPool_basic
--- PASS: TestAccComputeTargetPool_basic (44.86s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	90.958s

Plus the tests that are currently failing because of the upstream change:

TF_ACC=1 go test ./builtin/providers/google -v -run=TestAccComputeForwardingRule -timeout 120m
=== RUN   TestAccComputeForwardingRule_importBasic
--- PASS: TestAccComputeForwardingRule_importBasic (46.23s)
=== RUN   TestAccComputeForwardingRule_basic
--- PASS: TestAccComputeForwardingRule_basic (46.01s)
=== RUN   TestAccComputeForwardingRule_singlePort
--- PASS: TestAccComputeForwardingRule_singlePort (45.25s)
=== RUN   TestAccComputeForwardingRule_ip
--- PASS: TestAccComputeForwardingRule_ip (45.75s)
=== RUN   TestAccComputeForwardingRule_internalLoadBalancing
--- PASS: TestAccComputeForwardingRule_internalLoadBalancing (67.55s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/google	250.966s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.