Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for aws_ssm_patch_baseline #14954

Merged
merged 3 commits into from
May 31, 2017

Conversation

PaulAtkins
Copy link
Contributor

@PaulAtkins PaulAtkins commented May 31, 2017

Add support for:

  • aws_ssm_patch_baseline
  • aws_ssm_patch_group

First attempt at go and terraform, so welcome any feedback :)

make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSSSMPatch'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/31 07:34:21 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSSSMPatch -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
--- PASS: TestAccAWSSSMPatchBaseline_basic (74.95s)
=== RUN   TestAccAWSSSMPatchGroup_basic
--- PASS: TestAccAWSSSMPatchGroup_basic (46.70s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    121.661s

@PaulAtkins PaulAtkins changed the title [WIP] provider/aws: Add support for aws_ssm_patch_baseline provider/aws: Add support for aws_ssm_patch_baseline May 31, 2017
@stack72
Copy link
Contributor

stack72 commented May 31, 2017

This LGTM! Thanks for this @PaulAtkins

% make testacc TEST=./builtin/providers/aws/ TESTARGS='-run=TestAccAWSSSMPatch'                                                              ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/05/31 20:14:00 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws/ -v -run=TestAccAWSSSMPatch -timeout 120m
=== RUN   TestAccAWSSSMPatchBaseline_basic
--- PASS: TestAccAWSSSMPatchBaseline_basic (49.14s)
=== RUN   TestAccAWSSSMPatchGroup_basic
--- PASS: TestAccAWSSSMPatchGroup_basic (33.54s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	82.699s

I am going to follow up with a small commit to add the links to the docs pages

@stack72 stack72 merged commit d3eed78 into hashicorp:master May 31, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants