Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: New resource: aws_security_group_attachment #15167

Closed
wants to merge 5 commits into from
Closed

provider/aws: New resource: aws_security_group_attachment #15167

wants to merge 5 commits into from

Commits on Jun 7, 2017

  1. provider/aws: New resource: aws_security_group_attachment 

    Tests and docs to come.
    Chris Marchesi committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    e046c48 View commit details
    Browse the repository at this point in the history

  2. provider/aws: Greatly simplify aws_security_group_attachment 

    ... by removing instance_id. It just dawned on me that one can simply
reference the primary_network_interface_id from the aws_instance
resource to get the same effect. This removes a bunch of unnecessary
logic from the resource, and makes things explicit in what you are
supposed to do.
    Chris Marchesi committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    4af78e9 View commit details
    Browse the repository at this point in the history

  3. provider/aws: Tests for aws_security_group_attachment 

    And added into provider.go. Just docs remaining now.
    Chris Marchesi committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    e3611f6 View commit details
    Browse the repository at this point in the history

  4. provider/aws: Add second test through data source 

    This will probably be one of the more used use cases, as it allows TF to
hook a security group into an instance or ENI not necessarily managed by
Terraform, where you don't necessarily want to manage instance
lifecycle.
    Chris Marchesi committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    74285ff View commit details
    Browse the repository at this point in the history

  5. provider/aws: Documentation for aws_security_group_attachment 

    Two examples: one with a full-managed instance, and one that works
through the data source.
    Chris Marchesi committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    2a909e8 View commit details
    Browse the repository at this point in the history