config/lang: support math on variables through implicits #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Determine the resulting type we want. We do this by going over | ||
| // every expression until we find one with a type we recognize. | ||
| // We do this because the first expr might be a string ("var.foo") | ||
| // and we need to know what to implicit to. |
There was a problem hiding this comment.
"Implicit" as a verb? I like it!
| // We found the type, so leave | ||
| if exit { | ||
| break | ||
| } |
There was a problem hiding this comment.
For a minute I was like "what about the error case?" but now I see it.
If we don't hit anything in the range we like - the initial mathFunc and mathType will implicit everything for int math below. 👍
|
Good good good. 👌 |
mitchellh
added a commit
that referenced
this pull request
Apr 14, 2015
config/lang: support math on variables through implicits
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381
We always meant for conversion to the correct numeric type to be implicit. There is an edge case though if the first operand to math ops is not a primitive: the type inference doesn't work. This fixes that issue.