Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configurable timeouts in AWS OpsWorks Instances. #15224

Conversation

charles-at-geospock
Copy link

We have found that the creation and update of the OpsWorks Instances often
times out with the default 10 minute timeout. This change introduces a
configuration for 'Create', 'Delete' and 'Update' timeouts. The actual
implementation is required to start or stop the instance, which is the
operation which times out, and which of these is performed (particularly
for the 'Update' operation) is dependant on the change needed.

The change introduces the timeouts, adds a simple test that the format
is parsed, and provides documentation for these new parameters.

Code has been tested with AWS and the timeouts appear to be effective.

We have found that the creation and update of the OpsWorks Instances often
times out with the default 10 minute timeout. This change introduces a
configuration for 'Create', 'Delete' and 'Update' timeouts. The actual
implementation is required to start or stop the instance, which is the
operation which times out, and which of these is performed (particularly
for the 'Update' operation) is dependant on the change needed.

The change introduces the timeouts, adds a simple test that the format
is parsed, and provides documentation for these new parameters.
@stack72
Copy link
Contributor

stack72 commented Jun 14, 2017

Hi @charles-at-geospock

Sorry to ask about this, please can you reopen this PR against https://github.com/terraform-providers/terraform-provider-aws?

The functionality is very good and I'd like to get this merged for you

Thanks

Paul

@stack72 stack72 added the waiting-response An issue/pull request is waiting for a response from the community label Jun 14, 2017
@charles-at-geospock
Copy link
Author

Yeah, I'm looking at it right now (and for the last couple of hours, whilst I've been looking at how things have changed in the last few days). I've sworn a lot about it, from seeing 'conflicts' (oh, I probably just have to fix up a line or two) to 'new repo, and testing scheme'. Should be up in an hour or so.

I guess I just picked the wrong week to give up glue sniffing submit a PR 😆

@stack72
Copy link
Contributor

stack72 commented Jun 14, 2017

<3 thanks @charles-at-geospock

@charles-at-geospock
Copy link
Author

charles-at-geospock commented Jun 14, 2017

Pull request created in the providers repository.
hashicorp/terraform-provider-aws#857

Whee!

@charles-at-geospock charles-at-geospock deleted the configurable-timeouts-aws-opsworks-2 branch June 14, 2017 15:22
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement provider/aws waiting-response An issue/pull request is waiting for a response from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants