applying a plan should use the refreshed state #15421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apparentlymart
force-pushed
the
jbardin/apply-plan-state
branch
2 times, most recently
from
98b48a0 to
67c6a53
Compare
When applying a plan, a copy of the plan's state is initially persisted to state storage, which may in turn increment the serial number. The apply operation stil uses the state stored in the plan, which may have a lower serial number. Now we no longer use the plan state when building the apply context, but still perform a sanity check to ensure that the state be used is equivalent.
apparentlymart
force-pushed
the
jbardin/apply-plan-state
branch
from
67c6a53 to
ac615e7
Compare
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying a plan, a copy of the plan's state is initially persisted
to state storage, which may in turn increment the serial number. The
apply operation stil uses the state stored in the plan, which may have a
lower serial number.
Now we no longer use the plan state when building the apply context, but
still perform a sanity check to ensure that the state be used is
equivalent.
TODO: test case