changing route53_zone.name_servers back to list #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine, as long as we can sort them. Can you sort the nameservers? This will prevent the AWS API returning different orders and messing things up. |
|
@mitchellh I've changed them to be sorted. |
|
@mitchellh @phinze Any chance this can get merged? |
|
LGTM |
phinze
added a commit
that referenced
this pull request
Apr 29, 2015
changing route53_zone.name_servers back to list
|
Thanks. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1525 and #1573, I had to change the computed
name_serversattribute back to a list so the values could be referenced elsewhere as they are in the docs. Until we can reference set elements correctly, this was about the only way I could think of to get it to work. I've verified that the name servers are returned from the AWS API are in a consistent ordering as well.