Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listener.ssl_certificate_id support to AWS ELB #176

Merged
merged 1 commit into from
Oct 2, 2014

Conversation

jpadvo
Copy link
Contributor

@jpadvo jpadvo commented Aug 11, 2014

This hopefully will tick off ELB > SSL Configuration for issue 28. Relies on pull request 78 for mitchellh/goamz.

@jpadvo
Copy link
Contributor Author

jpadvo commented Aug 11, 2014

The reason for the build failure may be that I added a test with a placeholder value for an SSL certificate id - your test account would need an SSL certificate, and the id in the test would need to be updated.

@pearkes
Copy link
Contributor

pearkes commented Aug 20, 2014

Hm, so, I'd say if the tests are that dependent on having an SSL cert on your account we should do what we do for other unique things, which is set an environment variable (AWS_SSL_CERTIFICATE_ID=foobar) and only have that test run if that var is set. You can see how we do that here and here. Just make a specific precheck for the SSL test that checks for that env var. We can assume we'll only occasionally run this test, but that's ok! Can you also rebase against master and fix up these conflicts?

Thanks for the contribution! SSL for ELB is a big win.

pmoust added a commit to pmoust/terraform that referenced this pull request Oct 2, 2014
@pearkes pearkes merged commit 8d97c36 into hashicorp:master Oct 2, 2014
@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants