Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: failing test for a bad module cycle #1797

Merged
merged 1 commit into from
May 5, 2015

Conversation

phinze
Copy link
Contributor

@phinze phinze commented May 5, 2015

passing output of one module into input of the following module results
in a cycle

passing output of one module into input of the following module results
in a cycle
@mitchellh
Copy link
Contributor

Merging this into the branch, goign to work on this.

mitchellh added a commit that referenced this pull request May 5, 2015
core: failing test for a bad module cycle
@mitchellh mitchellh merged commit 803348d into b-module-deps May 5, 2015
@mitchellh mitchellh deleted the b-flatten-modules-cycle branch May 5, 2015 17:54
@mitchellh
Copy link
Contributor

So I figured this out: this cycle doesn't exist as long as PruneDestroyTransformer is properly run. But its not run because Verbose is set to true? That transformer is pretty important to run to get rid of real cycles that can exist in pathological cases. We are able to avoid those cycles by pruning vertices that generally don't need to be there because the case generally isn't pathological.

@ghost
Copy link

ghost commented May 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants