switch to updated aws-sdk-go credentials

[pmoust]

Seems aws-sdk-go has changed a bit..

rant, golang dependency management (or lack thereof) sucks, should we vendor deps?

[radeksimko]

rant, golang dependency management (or lack thereof) sucks, should we vendor deps?

I think there are some good sides of the current state - it forces you to deal with incompatibilities soon, instead of letting the SW die with old versions of dependencies. :P

I'm afraid the change will be more difficult than just replacing aws.DetectCreds with credentials.NewStaticCredentials, as the naming suggests, these are two different functions.

[radeksimko]

#1804
cc @svanharmelen

[svanharmelen]

Ah sorry @pmoust! I totally missed this one and just merged in PR #1804 to fix the same thing as I was working on some other PR's... So will close this one as it's already fixed now.

Still thanks for the PR and I'll make sure to double check first next time 😉

[radeksimko]

@svanharmelen even though this is now working for the most basic examples, it's a step backward when looking at #1470

[svanharmelen]

@radeksimko I actually executed a couple of acceptance tests and they run successfully (creating some instances and an S3 bucket), so could you point out any specific things that would break by this change?

Will also run a full AWS acceptance test cycle (running as we speak) to see what tests (if any) will not work with this fix.

As for #1470... I'm not sure if the current fix needs some additional work to better serve the changes made in that PR, but my intention at this moment was to fix the immediate issue (master being broken) so people can build and test with master again. Of course that doesn't mean any additional improvements and/or updates aren't welcome or maybe even needed...

[pmoust]

@svanharmelen we were unable to build with current aws-sdk-go.

[pmoust]

@svanharmelen ah I just checked you already merged ;) ty

[svanharmelen]

@radeksimko just finished the AWS acceptance tests and did receive a coupe of errors, but those where not related to the credentials used but instead caused by changes in the logic and/or tests of the AWS provider... So it seems the tests aren't being run to consistently lately 😉

So for now I think the fix is good, but again there is always room for improvement... Thx!

[catsby]

rant, golang dependency management (or lack thereof) sucks, should we vendor deps?

We've considered this. There is a mailing list thread on golang-nuts about an "official" type system here, but I suspect it's a ways off. Until then, we're just not sold on any current solutions out there.

As Radek said, there are some benefits to it

[mitchellh]

Hm, I don't think that this will load credentials from the env anymore? I took a look at the upstream code and I don't think NewStaticCredentials will grab a lot of other types of creds anymore. I think we need to use NewChainCredentials and chain a series of providers.

[mitchellh]

Whoops didn't see #1804

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.