Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable count > 1 for AWS ELB by optionally generating random names #181

Closed
wants to merge 1 commit into from

Conversation

jpadvo
Copy link
Contributor

@jpadvo jpadvo commented Aug 11, 2014

Name was required for AWS ELB resources, and AWS requires a unique name for each ELB. This made it so that a count greater than 1 would cause repeated names, which blocked the creation of all but the first ELB.

With this commit, if the name is left blank, a random name will be provided so that count greater than 1 can be used for ELBs.

@jpadvo
Copy link
Contributor Author

jpadvo commented Aug 11, 2014

I was digging around the issues, and found that the need for this would be obviated by #111. This pull is kind of hacky, and might not actually be worth it.

@pearkes
Copy link
Contributor

pearkes commented Aug 19, 2014

Hm, it's an interesting use case. I agree that this should be done higher level, however. We don't have any other random generation of attributes in Terraform and I think that might trip someone up.

Appreciate the changes but going to close in favor of a "first class" solution per #111 as you noted. Thanks!

@pearkes pearkes closed this Aug 19, 2014
@jpadvo
Copy link
Contributor Author

jpadvo commented Aug 19, 2014

👍

@ghost ghost locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants