Fixed bug where docker_container resource was not working properly with swarm

[jwthomp]

The docker_container resource was failing to work with Swarm as it was using the container name to test if it had started on a Swarm cluster. As Swarm prepends the hostname to a container name, this was failing. I have modified fetchDockerContainer to use the container's sha rather than it's name to test that it is still running.

[mitchellh]

Hey @jefferai do you mind helping with a review on this?

[jefferai]

LGTM. Older versions (possibly unreleased) had various functions calling fetchDockerContainer so the ID could not be relied on to be available, but at this point it's only called from within Read so I believe it should be available in all cases.

[josephholsten]

@mitchellh is this easy enough to manually merge? or does it need someone to rebase the patch for you all?

[josephholsten]

rebased this thing at #3364

@phinze, @jefferai: should be ready to you to look at

[phinze]

Closing in favor of #3364

[jen20]

This actually landed in #4148!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.