Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore vpc endpoint routes #2064

Closed

Conversation

ojongerius
Copy link
Contributor

Fixes #2063

@radeksimko
Copy link
Member

Thanks for noticing.

I feel we should add a proper support for VPC endpoints, but there's no support in the upstream AWS Go SDK yet.

I will keep asking the AWS support.

@ojongerius
Copy link
Contributor Author

@radeksimko cheers!

Terraform support for S3 VPC endpoints would be amazing, it makes a HUGE difference the amount of traffic flowing through our routers. Entertainingly enough we noticed Cloudformation currently also chokes on route tables containing S3 VPC endpoint routes object.

This patch at least fixes the current situation.

@gjohnson
Copy link

gjohnson commented Jun 3, 2015

Looks like it was added upstream this week. Be awesome to have this support.

@radeksimko
Copy link
Member

@gjohnson Yes, "we ask for it, we get it". 😃

I already started working on EFS which was added in the same commit and unless someone will be quicker, I may start working on VPC endpoints as well after finishing EFS, so far it's open for everyone (it always is though :) ).

@gjohnson
Copy link

gjohnson commented Jun 3, 2015

@radeksimko I may have time to add endpoints while your on EFS, ping you on the PR if I get to it.

@radeksimko
Copy link
Member

@ojongerius Thanks, but @gjohnson came up with slightly cleaner solution to this issue.
We also now support VPC endpoints, so these don't have to be managed outside Terraform.

See #2695 which has been just merged.

@radeksimko radeksimko closed this Jul 14, 2015
@ojongerius ojongerius deleted the ignore_vpc_endpoint_routes branch July 16, 2015 00:48
@ghost
Copy link

ghost commented May 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform panics on calculating diffs for route tables containing S3 VPC endpoint routes.
3 participants